Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move openid client to optional dependencies. #837

Merged
merged 1 commit into from Jul 12, 2022

Conversation

brendandburns
Copy link
Contributor

Fixes #832

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from drubin July 3, 2022 04:10
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2022
@brendandburns
Copy link
Contributor Author

cc @davidgamero if you get a chance to look at this.

@davidgamero
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@davidgamero: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rugvip
Copy link

Rugvip commented Jul 11, 2022

We've also been hit by this and are working around the engines restriction through https://www.npmjs.com/package/openid-client-any-engine. It's a re-published package that only rewrites the name, description and engines in package.json. Feel free to depend on it if you want to as well. More context over in backstage/backstage#12558, with the script used to re-publish the package in backstage/backstage@ab00287

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit c142034 into kubernetes-client:master Jul 12, 2022
@loopingz
Copy link

Do you plan to do a fix version 17.0.1, openid-client issue made the client incompatible with Node 18

@benjdlambert
Copy link

ping @brendandburns, can we get a release of this to npm with the optionalDependencies change?

@mabasic
Copy link

mabasic commented Aug 13, 2022

Can we get a release?

btw. Until the release you can add the package like so to use the master branch:

yarn add @kubernetes/client-node@github:kubernetes-client/javascript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation failed with error message
7 participants