New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Node.js versions to 16 & 18 #12558
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7605c11
bump Node.js to 16 & 18
Rugvip 384eaa2
changests: add changesets for Node.js 18 bump
Rugvip 1d43bcf
auth-backend: add script for re-publishing openid-client
Rugvip 4ca99cc
auth-backend: use openid-client-any-engine
Rugvip 009db8b
root: add node-gyp dep to fill missing dep of ssh2
Rugvip 24b06ff
root: work around openid-client with resolutions
Rugvip 6fb165f
scripts/check-type-dependencies: work around exports resolution
Rugvip cfb30b7
bump @kubernetes/client-node to 0.17.1
Rugvip 7bcb96a
workflows: work around missing node-canvas binaries for node 18
Rugvip 21339ea
backend-common: work around premature close errors
Rugvip 90e5b42
catalog-backend-module-github: work around lack of msw fetch support …
Rugvip 428e5d5
Revert "root: work around openid-client with resolutions"
Rugvip 40c578e
Revert "auth-backend: use openid-client-any-engine"
Rugvip 442cbba
Revert "auth-backend: add script for re-publishing openid-client"
Rugvip 2008aec
pin @kubernetes/client-node to working version
Rugvip ee35a69
auth-backend: bump openid-client to most recent version
Rugvip a8dac60
Revert "workflows: work around missing node-canvas binaries for node 18"
Rugvip 93554b0
Revert "backend-common: work around premature close errors"
Rugvip e92aa15
bump canvas to 2.10.2
Rugvip 88f99b8
bump tar to 6.1.12
Rugvip f121e3f
e2e-test: add wait before checking backend availability
Rugvip 864c876
create-app: fix default backend listen config and comments
Rugvip File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@backstage/plugin-cost-insights': patch | ||
'@backstage/plugin-techdocs': patch | ||
--- | ||
|
||
Bumped `canvas` dependency to the latest version, which has better Node.js v18 support. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@backstage/backend-common': patch | ||
'@backstage/cli': patch | ||
--- | ||
|
||
Bumped `tar` dependency to `^6.1.12` in order to ensure Node.js v18 compatibility. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'@backstage/backend-common': patch | ||
'@backstage/plugin-kubernetes': patch | ||
'@backstage/plugin-kubernetes-backend': patch | ||
'@backstage/plugin-kubernetes-common': patch | ||
--- | ||
|
||
Pin `@kubernetes/client-node` version to `0.17.0`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- | ||
'@backstage/create-app': patch | ||
--- | ||
|
||
Switched Node.js version to support version 16 & 18, rather than 14 & 16. To switch the Node.js version in your own project, apply the following change to the root `package.json`: | ||
|
||
```diff | ||
"engines": { | ||
- "node": "14 || 16" | ||
+ "node": "16 || 18" | ||
}, | ||
``` | ||
|
||
As well as the following change to `packages/app/package.json`: | ||
|
||
```diff | ||
- "@types/node": "^14.14.32", | ||
+ "@types/node": "^16.11.26", | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@backstage/cli': minor | ||
--- | ||
|
||
Switched `tsconfig.json` to target and support `ES2021`, in line with the bump to Node.js 16 & 18. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
--- | ||
'@backstage/create-app': patch | ||
--- | ||
|
||
Fixed incorrect comments in the templated `app-config.yaml` and `app-config.production.yaml`. The `backend.listen` directive is not in fact needed to override the `backend.baseUrl`, the backend listens to all interfaces by default. The configuration has also been updated to listen to all interfaces, rather than just IPv4 ones, as this is required for Node.js v18. The production configuration now also shows the option to specify `backend.listen` as a single string. | ||
|
||
To apply this changes to an existing app, make the following change to `app-config.yaml`: | ||
|
||
```diff | ||
- # Uncomment the following host directive to bind to all IPv4 interfaces and | ||
- # not just the baseUrl hostname. | ||
- # host: 0.0.0.0 | ||
+ # Uncomment the following host directive to bind to specific interfaces | ||
+ # host: 127.0.0.1 | ||
``` | ||
|
||
And the following change to `app-config.production.yaml`: | ||
|
||
```diff | ||
- listen: | ||
- port: 7007 | ||
- # The following host directive binds to all IPv4 interfaces when its value | ||
- # is "0.0.0.0". This is the most permissive setting. The right value depends | ||
- # on your specific deployment. If you remove the host line entirely, the | ||
- # backend will bind on the interface that corresponds to the backend.baseUrl | ||
- # hostname. | ||
- host: 0.0.0.0 | ||
+ # The listener can also be expressed as a single <host>:<port> string. In this case we bind to | ||
+ # all interfaces, the most permissive setting. The right value depends on your specific deployment. | ||
+ listen: ':7007' | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
node-version: [14.x] | ||
node-version: [16.x] | ||
|
||
env: | ||
CI: true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
node-version: [14.x] | ||
node-version: [16.x] | ||
|
||
env: | ||
CI: true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
node-version: [14.x, 16.x] | ||
node-version: [16.x, 18.x] | ||
|
||
env: | ||
CI: true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
node-version: [14.x, 16.x] | ||
node-version: [16.x, 18.x] | ||
|
||
env: | ||
CI: true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
node-version: [14.x] | ||
node-version: [16.x] | ||
|
||
env: | ||
CI: true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
node-version: [14.x, 16.x] | ||
node-version: [16.x, 18.x] | ||
|
||
env: | ||
CI: true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
ARG IMAGE_TAG=14-alpine | ||
ARG IMAGE_TAG=16-alpine | ||
|
||
FROM node:${IMAGE_TAG} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ | |
|
||
|
||
|
||
FROM node:14-buster AS build | ||
FROM node:16-buster AS build | ||
|
||
RUN mkdir /app | ||
COPY . /app | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmmm, all of the
??=
and stuff, right? :)