Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse string export names by default (moduleStringNames) #13195

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Ref: tc39/ecma262#2154

This syntax is effectively stage 4. It didn't go through the proposals process, but:

  • It reached consensus in the Sept 2020 meeting, pending test262 tests and implementations
  • It now has test262 tests
  • It has been now implemented in different major engines (v8, SM and JSC)

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories area: modules pkg: parser labels Apr 22, 2021
@nicolo-ribaudo nicolo-ribaudo changed the base branch from feat-7.14.0/preset-env to feat-7.14.0/parser-updates April 22, 2021 22:04
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 22, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45534/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 22, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d4f77d8:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo
Copy link
Member Author

Note that we don't have a plugin to transform this.

It would be possible to transform imports:

import { "a b" as x } from "mod";
x;

// ->

import * as _mod from "mod";
_mod["a b"];

but I think that exports are impossible to transpile.

@nicolo-ribaudo nicolo-ribaudo merged commit 0512869 into babel:feat-7.14.0/parser-updates Apr 23, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the moduleStringNames-default branch April 23, 2021 07:07
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 23, 2021
9 tasks
nicolo-ribaudo added a commit that referenced this pull request Apr 23, 2021
* Parse string epxort names by default (`moduleStringNames`)

* Remove remaining references
nicolo-ribaudo added a commit that referenced this pull request Apr 26, 2021
* Parse string epxort names by default (`moduleStringNames`)

* Remove remaining references
nicolo-ribaudo added a commit that referenced this pull request Apr 28, 2021
* Parse string epxort names by default (`moduleStringNames`)

* Remove remaining references
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: modules outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants