Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser features for 7.14.0 #13098

Merged
merged 12 commits into from Apr 28, 2021
Merged

Parser features for 7.14.0 #13098

merged 12 commits into from Apr 28, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Apr 3, 2021

⚠️ Use the "Rebase and merge" button!

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 3, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45643/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 52a59b1:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@sosukesuzuki
Copy link
Member

Should we mention about error code at parser doc?

@nicolo-ribaudo
Copy link
Member Author

Yeah that's a good idea!

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Apr 13, 2021
@g-plane
Copy link
Contributor

g-plane commented Apr 17, 2021

So strange...Why did my commits disappear?

/cc @JLHwung

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Apr 17, 2021

Uh probably an error while rebasing... I have a local copy of this branch before the last rebase, I can restore them this evening.

@JLHwung
Copy link
Contributor

JLHwung commented Apr 17, 2021

So strange...Why did my commits disappear?

They didn't disappear (65bf9f4, 265e2b3), but git replaces the author name to mine, probably because I resolved the merge conflicts.

I have rebased again but amended with your name, let me know if it looks good.

@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.14.0/parser-updates branch 4 times, most recently from 0512869 to a9f5e07 Compare April 23, 2021 22:37
sosukesuzuki and others added 8 commits April 26, 2021 22:31
* support TS 4.3 `override` syntax in class

* fix types

* fix types

* tweak error message

* update TypeScript commit

* split tests

* add more tests

* update allowlist

* disallow `override` with `declare`

* disallow `override` in non-sub class

* update TypeScript allowlist

* rename error message key

* add more tests
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
JLHwung and others added 2 commits April 26, 2021 22:31
* feat: materialize class features

* chore: move testcases to es2022

* chore: update test fixtures

* chore: remove classPr\w+ from options.json

* chore: remove empty options.json

* update flow test allowlist

* update typescript allowlist
* Parse string epxort names by default (`moduleStringNames`)

* Remove remaining references
gkz and others added 2 commits April 27, 2021 19:27
* [ts] Enforce order for the `override` modifier

* generator

* Add more checks

* Update TS tests
@nicolo-ribaudo nicolo-ribaudo merged commit 22b0eb0 into main Apr 28, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the feat-7.14.0/parser-updates branch April 28, 2021 16:21
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release umbrella ☂️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants