Update babel parser #10802
Merged
Update babel parser #10802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
commented
Apr 30, 2021
| "Unexpected token (4:10) | ||
| 2 | static #x = 42; | ||
| 3 | static y; | ||
| > 4 | static { |
There was a problem hiding this comment.
This should be fixed by babel/parser.
This was referenced Apr 30, 2021
fisker
reviewed
Apr 30, 2021
src/language-js/parser-babel.js
Outdated
|
|
||
| return true; | ||
| function shouldRethrowRecoveredError(error) { |
There was a problem hiding this comment.
Remove this function, use allowedMessageCodes directly.
fisker
reviewed
Apr 30, 2021
| "throwExpressions", | ||
| "classPrivateMethods", |
There was a problem hiding this comment.
Can moduleStringNames plugin removed?
fisker
reviewed
Apr 30, 2021
| // - https://github.com/babel/babel/blob/v7.14.0/packages/babel-parser/src/plugins/flow/index.js#L51-L140 | ||
| // - https://github.com/babel/babel/blob/v7.14.0/packages/babel-parser/src/plugins/jsx/index.js#L23-L39 | ||
| const allowedMessageCodes = new Set([ | ||
| "StrictNumericEscape", |
There was a problem hiding this comment.
The error codes seem less readable than the message. 😢
There was a problem hiding this comment.
Probably these error codes are used by only us now, so we can fix too less readable messages on Babel side.
sosukesuzuki
force-pushed
the
update-babel-parser
branch
from
f06ebc2
to
69d4657
Compare
sosukesuzuki
commented
May 1, 2021
Comment on lines
-13
to
-24
| 'interface = "foo";', | ||
| "interface + 3;", | ||
| "interface();", | ||
| "class interface {}", | ||
| "interface ? true : false;", | ||
| "function interface() {}", | ||
| 'import interface from "foo";', | ||
| "interface.foo;", | ||
| "new interface();", | ||
| '(interface, "foo");', | ||
| "void interface;", | ||
| 'const interface = "foo";', |
There was a problem hiding this comment.
This change makes the Reserved word check rough...
fisker
approved these changes
May 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error Codes are introduced in babel/parser since Babel 7.14.0. Also almost error messages throw by babel/parser are fixed for consistent.
Checklist
✨Try the playground for this PR✨