Mark WeakMaps of private fields as pure
#13194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Output optimization 🔬
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45529/ |
|
We should also annotate https://github.com/babel/babel/pull/13172/files#diff-8a6df468afdcc49425d50abb711a0b1439b2120a6c51814cc563ca10ba7730f1R1 as pure. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5c6fb6b:
|
JLHwung
approved these changes
Apr 22, 2021
I'll rebase this on top of the Babel 7.14 branch and do it in this PR |
|
Is this commit from yesterday 66181db intentionally in the MR? |
|
Nope, I need to rebase |
nicolo-ribaudo
force-pushed
the
private-weakmap-pure
branch
from
5c6fb6b
to
6b14bdc
Compare
kaicataldo
approved these changes
Apr 23, 2021
5 tasks
nicolo-ribaudo
added a commit
that referenced
this pull request
Apr 28, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/*#__PURE__*/annotation lets terser strip away thoseWeakMaps when the class is unused. TheclassPrivateFieldLooseKeyisn't technically pure (since it uses a global counter), but it can still be safely removed by terser.