Also for brand checks

babel · Apr 22, 2021 · 6b14bdc · 6b14bdc
1 parent 24ed392
commit 6b14bdc
Show file tree

Hide file tree

Showing 18 changed files with 30 additions and 26 deletions.
diff --git a/packages/babel-plugin-proposal-private-property-in-object/package.json b/packages/babel-plugin-proposal-private-property-in-object/package.json
@@ -17,7 +17,7 @@
     "babel-plugin"
   ],
   "dependencies": {
-    "@babel/helper-compilation-targets": "workspace:^7.12.17",
+    "@babel/helper-annotate-as-pure": "workspace:^7.12.13",
     "@babel/helper-create-class-features-plugin": "workspace:^7.13.0",
     "@babel/helper-plugin-utils": "workspace:^7.13.0",
     "@babel/plugin-syntax-private-property-in-object": "workspace:^7.13.0"

diff --git a/packages/babel-plugin-proposal-private-property-in-object/src/index.js b/packages/babel-plugin-proposal-private-property-in-object/src/index.js
@@ -5,6 +5,7 @@ import {
   FEATURES,
   injectInitialization as injectConstructorInit,
 } from "@babel/helper-create-class-features-plugin";
+import annotateAsPure from "@babel/helper-annotate-as-pure";
 
 export default declare(({ assertVersion, types: t, template }, { loose }) => {
   assertVersion(7);
@@ -72,7 +73,10 @@ export default declare(({ assertVersion, types: t, template }, { loose }) => {
 
       inject(reference, template.expression.ast`${t.cloneNode(id)}.add(this)`);
 
-      outerClass.insertBefore(template.ast`var ${id} = new WeakSet()`);
+      const newExpr = t.newExpression(t.identifier("WeakSet"), []);
+      annotateAsPure(newExpr);
+
+      outerClass.insertBefore(template.ast`var ${id} = ${newExpr}`);
     }
 
     return t.cloneNode(id);

diff --git a/...gin-proposal-private-property-in-object/test/fixtures/to-native-fields/accessor/output.js b/...gin-proposal-private-property-in-object/test/fixtures/to-native-fields/accessor/output.js
@@ -1,4 +1,4 @@
-var _FooBrandCheck = new WeakSet();
+var _FooBrandCheck = /*#__PURE__*/new WeakSet();
 
 class Foo {
   constructor() {

diff --git a/...erty-in-object/test/fixtures/to-native-fields/class-expression-in-default-param/output.js b/...erty-in-object/test/fixtures/to-native-fields/class-expression-in-default-param/output.js
@@ -1,7 +1,7 @@
 (x = (() => {
   var _fooBrandCheck;
 
-  return _fooBrandCheck = new WeakSet(), class {
+  return _fooBrandCheck = /*#__PURE__*/new WeakSet(), class {
     #foo = void _fooBrandCheck.add(this);
 
     test(other) {

diff --git a/...ate-property-in-object/test/fixtures/to-native-fields/class-expression-instance/output.js b/...ate-property-in-object/test/fixtures/to-native-fields/class-expression-instance/output.js
@@ -1,7 +1,7 @@
 function fn() {
   var _privBrandCheck;
 
-  return new (_privBrandCheck = new WeakSet(), class {
+  return new (_privBrandCheck = /*#__PURE__*/new WeakSet(), class {
     #priv = void _privBrandCheck.add(this);
 
     method(obj) {

diff --git a/...ivate-property-in-object/test/fixtures/to-native-fields/class-expression-static/output.js b/...ivate-property-in-object/test/fixtures/to-native-fields/class-expression-static/output.js
@@ -1,7 +1,7 @@
 function fn() {
   var _privBrandCheck;
 
-  return new (_privBrandCheck = new WeakSet(), class {
+  return new (_privBrandCheck = /*#__PURE__*/new WeakSet(), class {
     static #priv = void _privBrandCheck.add(this);
 
     method(obj) {

diff --git a/...plugin-proposal-private-property-in-object/test/fixtures/to-native-fields/field/output.js b/...plugin-proposal-private-property-in-object/test/fixtures/to-native-fields/field/output.js
@@ -1,6 +1,6 @@
 var _temp;
 
-var _fooBrandCheck = new WeakSet();
+var _fooBrandCheck = /*#__PURE__*/new WeakSet();
 
 class Foo {
   #foo = (_temp = 1, _fooBrandCheck.add(this), _temp);

diff --git a/...ate-property-in-object/test/fixtures/to-native-fields/half-constructed-instance/output.js b/...ate-property-in-object/test/fixtures/to-native-fields/half-constructed-instance/output.js
@@ -1,10 +1,10 @@
 var _temp, _temp2;
 
-var _FBrandCheck = new WeakSet();
+var _FBrandCheck = /*#__PURE__*/new WeakSet();
 
-var _xBrandCheck = new WeakSet();
+var _xBrandCheck = /*#__PURE__*/new WeakSet();
 
-var _yBrandCheck = new WeakSet();
+var _yBrandCheck = /*#__PURE__*/new WeakSet();
 
 class F {
   m() {

diff --git a/...ivate-property-in-object/test/fixtures/to-native-fields/half-constructed-static/output.js b/...ivate-property-in-object/test/fixtures/to-native-fields/half-constructed-static/output.js
@@ -1,8 +1,8 @@
 var _temp, _temp2;
 
-var _xBrandCheck = new WeakSet();
+var _xBrandCheck = /*#__PURE__*/new WeakSet();
 
-var _yBrandCheck = new WeakSet();
+var _yBrandCheck = /*#__PURE__*/new WeakSet();
 
 class F {
   static m() {

diff --git a/...lugin-proposal-private-property-in-object/test/fixtures/to-native-fields/method/output.js b/...lugin-proposal-private-property-in-object/test/fixtures/to-native-fields/method/output.js
@@ -1,4 +1,4 @@
-var _FooBrandCheck = new WeakSet();
+var _FooBrandCheck = /*#__PURE__*/new WeakSet();
 
 class Foo {
   constructor() {

diff --git a/...posal-private-property-in-object/test/fixtures/to-native-fields/multiple-checks/output.js b/...posal-private-property-in-object/test/fixtures/to-native-fields/multiple-checks/output.js
@@ -1,6 +1,6 @@
-var _xBrandCheck = new WeakSet();
+var _xBrandCheck = /*#__PURE__*/new WeakSet();
 
-var _ABrandCheck = new WeakSet();
+var _ABrandCheck = /*#__PURE__*/new WeakSet();
 
 class A {
   #x = (_ABrandCheck.add(this), void _xBrandCheck.add(this));

diff --git a/...property-in-object/test/fixtures/to-native-fields/nested-class-other-redeclared/output.js b/...property-in-object/test/fixtures/to-native-fields/nested-class-other-redeclared/output.js
@@ -1,8 +1,8 @@
 var _temp, _temp3;
 
-var _fooBrandCheck = new WeakSet();
+var _fooBrandCheck = /*#__PURE__*/new WeakSet();
 
-var _barBrandCheck2 = new WeakSet();
+var _barBrandCheck2 = /*#__PURE__*/new WeakSet();
 
 class Foo {
   #foo = (_temp = 1, _fooBrandCheck.add(this), _temp);
@@ -11,7 +11,7 @@ class Foo {
   test() {
     var _temp2;
 
-    var _barBrandCheck = new WeakSet();
+    var _barBrandCheck = /*#__PURE__*/new WeakSet();
 
     class Nested {
       #bar = (_temp2 = 2, _barBrandCheck.add(this), _temp2);

diff --git a/...ivate-property-in-object/test/fixtures/to-native-fields/nested-class-redeclared/output.js b/...ivate-property-in-object/test/fixtures/to-native-fields/nested-class-redeclared/output.js
@@ -1,14 +1,14 @@
 var _temp2;
 
-var _fooBrandCheck2 = new WeakSet();
+var _fooBrandCheck2 = /*#__PURE__*/new WeakSet();
 
 class Foo {
   #foo = (_temp2 = 1, _fooBrandCheck2.add(this), _temp2);
 
   test() {
     var _temp;
 
-    var _fooBrandCheck = new WeakSet();
+    var _fooBrandCheck = /*#__PURE__*/new WeakSet();
 
     class Nested {
       #foo = (_temp = 2, _fooBrandCheck.add(this), _temp);

diff --git a/...proposal-private-property-in-object/test/fixtures/to-native-fields/nested-class/output.js b/...proposal-private-property-in-object/test/fixtures/to-native-fields/nested-class/output.js
@@ -1,6 +1,6 @@
 var _temp;
 
-var _fooBrandCheck = new WeakSet();
+var _fooBrandCheck = /*#__PURE__*/new WeakSet();
 
 class Foo {
   #foo = (_temp = 1, _fooBrandCheck.add(this), _temp);

diff --git a/...proposal-private-property-in-object/test/fixtures/to-native-fields/static-field/output.js b/...proposal-private-property-in-object/test/fixtures/to-native-fields/static-field/output.js
@@ -1,6 +1,6 @@
 var _temp;
 
-var _fooBrandCheck = new WeakSet();
+var _fooBrandCheck = /*#__PURE__*/new WeakSet();
 
 class Foo {
   static #foo = (_temp = 1, _fooBrandCheck.add(this), _temp);

diff --git a/...ivate-property-in-object/test/fixtures/to-native-fields/static-shadowed-binding/output.js b/...ivate-property-in-object/test/fixtures/to-native-fields/static-shadowed-binding/output.js
@@ -1,4 +1,4 @@
-var _fooBrandCheck = new WeakSet();
+var _fooBrandCheck = /*#__PURE__*/new WeakSet();
 
 class A {
   static #foo = void _fooBrandCheck.add(this);

diff --git a/...s/babel-preset-env/test/fixtures/shipped-proposals/new-class-features-chrome-90/output.js b/...s/babel-preset-env/test/fixtures/shipped-proposals/new-class-features-chrome-90/output.js
@@ -1,4 +1,4 @@
-var _fooBrandCheck = new WeakSet();
+var _fooBrandCheck = /*#__PURE__*/new WeakSet();
 
 class A {
   #foo = void _fooBrandCheck.add(this);

diff --git a/yarn.lock b/yarn.lock
@@ -393,7 +393,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@babel/helper-compilation-targets@workspace:^7.12.17, @babel/helper-compilation-targets@workspace:^7.13.13, @babel/helper-compilation-targets@workspace:^7.13.16, @babel/helper-compilation-targets@workspace:^7.13.8, @babel/helper-compilation-targets@workspace:packages/babel-helper-compilation-targets":
+"@babel/helper-compilation-targets@workspace:^7.13.13, @babel/helper-compilation-targets@workspace:^7.13.16, @babel/helper-compilation-targets@workspace:^7.13.8, @babel/helper-compilation-targets@workspace:packages/babel-helper-compilation-targets":
   version: 0.0.0-use.local
   resolution: "@babel/helper-compilation-targets@workspace:packages/babel-helper-compilation-targets"
   dependencies:
@@ -1440,7 +1440,7 @@ __metadata:
   resolution: "@babel/plugin-proposal-private-property-in-object@workspace:packages/babel-plugin-proposal-private-property-in-object"
   dependencies:
     "@babel/core": "workspace:*"
-    "@babel/helper-compilation-targets": "workspace:^7.12.17"
+    "@babel/helper-annotate-as-pure": "workspace:^7.12.13"
     "@babel/helper-create-class-features-plugin": "workspace:^7.13.0"
     "@babel/helper-plugin-test-runner": "workspace:*"
     "@babel/helper-plugin-utils": "workspace:^7.13.0"