Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preset-env features for 7.14.0 #13167

Merged
merged 5 commits into from Apr 28, 2021
Merged

preset-env features for 7.14.0 #13167

merged 5 commits into from Apr 28, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Apr 16, 2021

⚠️ Use the "Rebase and merge" button!

@nicolo-ribaudo nicolo-ribaudo added this to the v7.14.0 milestone Apr 16, 2021
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.14.0/preset-env branch 2 times, most recently from a56dd89 to 0c58c2e Compare April 16, 2021 17:50
@JLHwung
Copy link
Contributor

JLHwung commented Apr 16, 2021

BTW we don't have a syntax plugin for private brand checks yet.

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 16, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45546/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a0f3edc:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo
Copy link
Member Author

BTW we don't have a syntax plugin for private brand checks yet.

Yeah I noticed while adding it to preset-env, I'm preparing a PR

@nicolo-ribaudo
Copy link
Member Author

Oh also we currently throw when compiling brand checks without compiling private fields 🙃

@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.14.0/preset-env branch 2 times, most recently from 838211b to d7d910a Compare April 20, 2021 21:39
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Apr 21, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit f30c99a into main Apr 28, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the feat-7.14.0/preset-env branch April 28, 2021 16:25
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release umbrella ☂️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants