replace archiver with @zip.js/zip.js #4769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctlai95
force-pushed
the
ctlai95/update-zip-stream
branch
5 times, most recently
from
01bdfa3
to
65ec6e8
Compare
The "minimum" is testing a very old version of vscode, which has an older nodejs. I think we can and should bump the minimum to a vscode version that has node 16. That will likely need to be a separate PR and may require some minor fixups in the tests, etc. |
ctlai95
force-pushed
the
ctlai95/update-zip-stream
branch
7 times, most recently
from
1c2dea8
to
2556aee
Compare
ctlai95
force-pushed
the
ctlai95/update-zip-stream
branch
from
2556aee
to
6f9e995
Compare
|
I've added #4787 to our current sprint, to unblock this. So please feel free to continue with the assumption that the vscode minimum will be bumped. |
ctlai95
force-pushed
the
ctlai95/update-zip-stream
branch
from
b41d29a
to
e7c95ae
Compare
ctlai95
force-pushed
the
ctlai95/update-zip-stream
branch
from
4be3f1a
to
7532d82
Compare
justinmk3
reviewed
May 8, 2024
packages/toolkit/package.json
Outdated
There was a problem hiding this comment.
was packages/toolkit/package.json an accidental commit?
There was a problem hiding this comment.
ah yes, let me revert it
pbalogh
reviewed
May 13, 2024
|
|
||
| export interface ZipStreamResult { | ||
| sizeInBytes: number | ||
| md5: string | ||
| hash: string |
pbalogh
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
archiverpackage usesfswhich is not available in the browser. Runningnpm run testWebresults in the following error:Solution
archiverwith@zip.js/zip.jswhich has browser support.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.