fix(featureDev): Prevent crash on large repos or unsupported encoding during file collection #4888
Conversation
jsalles
force-pushed
the
collect-files-crash
branch
from
7a8d0ab
to
3eb3438
Compare
jsalles
force-pushed
the
collect-files-crash
branch
from
3eb3438
to
858e55a
Compare
|
Just one more thing, are you able to add a changelog? I'm sure theres some users that would like to know this is fixed 😄 |
jsalles
force-pushed
the
collect-files-crash
branch
from
858e55a
to
0d1ceea
Compare
Yes, definitely! Just added a changelog with the bugfix :) |
| @@ -137,9 +153,9 @@ export async function prepareRepoData( | |||
| span: Metric<AmazonqCreateUpload> | |||
| ) { | |||
| try { | |||
| const files = await collectFiles(repoRootPaths, workspaceFolders, true) | |||
| const zip = new AdmZip() | |||
There was a problem hiding this comment.
the current approach used to zip files does not "stream" the zip creation so will also run into memory constraints.
please look at #4769 , can you rewrite this feature on top of that (after it lands)?
There was a problem hiding this comment.
What's the ETA of this being ready? Presume we want both these in the same wave of the toolkit?
There was a problem hiding this comment.
Yeah I'm happy to change our implementation to use the stream after it's merged.
There was a problem hiding this comment.
What's the ETA of this being ready?
The zip streaming won't be ready today, but hopefully next week. @ctlai95
jsalles
force-pushed
the
collect-files-crash
branch
from
0d1ceea
to
37b71b0
Compare
… during file collection
jsalles
force-pushed
the
collect-files-crash
branch
from
37b71b0
to
21428f5
Compare
Problem
There are currently 2 problems in featureDev when doing collection of repository files:
Solution
This CR fixes both problems by:
Users who try to use featureDev on a codebase larger than 200mb will see a message asking for a different workspace to be selected.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.