revert vscode version changes

aws · May 7, 2024 · e7c95ae · e7c95ae
1 parent b0b7bd1
commit e7c95ae
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 19 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -9,7 +9,7 @@
     "license": "Apache-2.0",
     "engines": {
         "npm": "^10.1.0",
-        "vscode": "^1.83.0"
+        "vscode": "^1.68.0"
     },
     "activationEvents": [
         "onStartupFinished",

diff --git a/packages/core/src/test/techdebt.test.ts b/packages/core/src/test/techdebt.test.ts
@@ -3,31 +3,34 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-// import assert from 'assert'
-// import * as semver from 'semver'
-// import * as env from '../shared/vscode/env'
+import assert from 'assert'
+import * as semver from 'semver'
+import * as env from '../shared/vscode/env'
 
 // Checks project config and dependencies, to remind us to remove old things
 // when possible.
 describe('tech debt', function () {
     it('vscode minimum version', async function () {
-        // const minVscode = env.getMinVscodeVersion()
-        // assert.ok(
-        //     semver.lt(minVscode, '1.75.0'),
-        //     'remove filesystemUtilities.findFile(), use vscode.workspace.findFiles() instead (after Cloud9 VFS fixes bug)'
-        // )
-        // assert.ok(
-        //     semver.lt(minVscode, '1.75.0'),
-        //     'remove AsyncLocalStorage polyfill used in `spans.ts` if Cloud9 is on node 14+'
-        // )
+        const minVscode = env.getMinVscodeVersion()
+
+        assert.ok(
+            semver.lt(minVscode, '1.75.0'),
+            'remove filesystemUtilities.findFile(), use vscode.workspace.findFiles() instead (after Cloud9 VFS fixes bug)'
+        )
+
+        assert.ok(
+            semver.lt(minVscode, '1.75.0'),
+            'remove AsyncLocalStorage polyfill used in `spans.ts` if Cloud9 is on node 14+'
+        )
     })
 
     it('nodejs minimum version', async function () {
-        // const minNodejs = env.getMinNodejsVersion()
+        const minNodejs = env.getMinNodejsVersion()
+
         // XXX: available since node 16, but not sure how much work this will be, yet.
-        // assert.ok(
-        //     semver.lt(minNodejs, '18.0.0'),
-        //     'with node16+, we can now use AbortController to cancel Node things (child processes, HTTP requests, etc.)'
-        // )
+        assert.ok(
+            semver.lt(minNodejs, '18.0.0'),
+            'with node16+, we can now use AbortController to cancel Node things (child processes, HTTP requests, etc.)'
+        )
     })
 })