Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NPM instead of yarn #5

Merged
merged 9 commits into from Mar 29, 2023
Merged

Use NPM instead of yarn #5

merged 9 commits into from Mar 29, 2023

Conversation

flenter
Copy link
Member

@flenter flenter commented Mar 28, 2023

Why?

We're using vsce to package/publish the extension. However that tool requires the package manager to support the list command (see also microsoft/vscode-vsce#517). However the latest versions of yarn don't support that.

This is an issue now because in order to support typescript we want to actually add a dependency and so the fix for using yarn no longer works (we ran the package command with the --no-dependencies parameter)

@flenter flenter mentioned this pull request Mar 28, 2023
@flenter flenter removed the request for review from brettimus March 29, 2023 09:22
@flenter flenter merged commit 4ec0ba0 into main Mar 29, 2023
1 check passed
@flenter flenter deleted the npm branch March 29, 2023 09:22
@arendjr
Copy link
Collaborator

arendjr commented Apr 25, 2023

This has been resolved by adding a Yarn plugin: #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants