Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NPM instead of yarn #5

Merged
merged 9 commits into from
Mar 29, 2023
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions .gitattributes

This file was deleted.

17 changes: 9 additions & 8 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,24 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: 19.x
cache: yarn
cache-dependency-path: yarn.lock
cache: 'npm'
cache-dependency-path: package-lock.json
node-version: 16.x

- name: install dependencies
run: yarn install --immutable
run: npm ci

- name: Prepare test
run: yarn pretest
run: npm run pretest
- name: Run test (linux)
run: xvfb-run -a yarn test
run: xvfb-run -a npm test
if: runner.os == 'Linux'
- name: Run test (other platforms)
run: yarn test
run: npm test
if: runner.os != 'Linux'

- name: Package extension
run: yarn run vsce package --no-dependencies
run: npx vsce package
- name: Store production artifacts
uses: actions/upload-artifact@v3
with:
Expand Down
873 changes: 0 additions & 873 deletions .yarn/releases/yarn-3.5.0.cjs

This file was deleted.

2 changes: 0 additions & 2 deletions .yarnrc

This file was deleted.

3 changes: 0 additions & 3 deletions .yarnrc.yml

This file was deleted.

2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## [Unreleased]

- [chore] switch from yarn to npm

## 0.0.1

- Initial release
8 changes: 6 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ def read_root():
return {"Hello": "World"}
```

### Unreleased

Change build: use npm instead of yarn 3.x. This is so we can use dependencies (required so we can support typescript)

### 0.0.1

Initial release which brings in basic Python support
Expand All @@ -52,11 +56,11 @@ Initial release which brings in basic Python support

This extension is build using:

- [yarn](yarnpkg.com)
- [npm](https://docs.npmjs.com/cli/v9)
- [esbuild](https://github.com/evanw/esbuild) as the bundler
- [dprint](https://github.com/dprint/dprint) as the formatter

In order to test the extension locally, you may want to install the following extensions:

- [Dprint code](https://marketplace.visualstudio.com/items?itemName=dprint.dprint). So vscode can format the code for you. You can also run `yarn format` before committing so all code is correctly formatted.
- [Dprint code](https://marketplace.visualstudio.com/items?itemName=dprint.dprint). So vscode can format the code for you. You can also run `npm run format` before committing so all code is correctly formatted.
- [esbuild Problem Matchers](https://marketplace.visualstudio.com/items?itemName=connor4312.esbuild-problem-matchers) This is needed when vscode to debug the extension.