Add typescript support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks ok, but we should wait until #5 is merged. After which we should test again if the extension works with the new setup |
keturiosakys
force-pushed
the
add-typescript-extension
branch
from
b650b02
to
bae2929
Compare
keturiosakys
force-pushed
the
add-typescript-extension
branch
from
bae2929
to
eb377cc
Compare
keturiosakys
force-pushed
the
add-typescript-extension
branch
from
ee3fb2b
to
37d6f1a
Compare
arendjr
approved these changes
Apr 12, 2023
arendjr
reviewed
Apr 12, 2023
| @@ -1,13 +1,16 @@ | |||
| { | |||
| "name": "autometrics", | |||
| "version": "0.0.1", | |||
| "lockfileVersion": 3, | |||
| "lockfileVersion": 2, | |||
There was a problem hiding this comment.
Are you using an older NPM version that caused the lock file version to be lowered?
There was a problem hiding this comment.
yeah that might be the case - I'm on npm v8 (node 18)
arendjr
reviewed
Apr 12, 2023
| @@ -76,7 +76,7 @@ export async function activate() { | |||
| configureTSPlugin(tsExtensionApi); | |||
| } | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| // rome-ignore lint/suspicious/noExplicitAny: pluginAPI is not typed | |||
flenter
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update installs and adds the TypeScript plugin to VSCode extension.