Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: CI failures with pytest 5.4.0 #10039

Closed
pllim opened this issue Mar 13, 2020 · 7 comments
Closed

TST: CI failures with pytest 5.4.0 #10039

pllim opened this issue Mar 13, 2020 · 7 comments
Labels
Bug 🔥 Critical testing Upstream Fix Required

Comments

@pllim
Copy link
Member

pllim commented Mar 13, 2020 •
edited

pytest 5.4.0 was released today and caused scientific-python/pytest-doctestplus#94 . Expect to see failures here until this is fixed or we have to pin pytest.

Also: #10039 (comment)

UPDATE: Seems like we can either go with astropy/ci-helpers#429 or #10040 for now until doctestplus is fixed.
@bsipocz
Copy link
Member

bsipocz commented Mar 13, 2020

Oh, well. I pinned the version in ci-helpers, but we don't use ci-helpers any more 🤦‍♀

@bsipocz bsipocz linked a pull request Mar 13, 2020 that will close this issue
MAINT: Trying to limit pytest version #10040
Closed
@pllim
Copy link
Member Author

pllim commented Mar 13, 2020

Or... we can bundle pytest (again). 😂

@pllim pllim mentioned this issue Mar 13, 2020
Merged
@MSeifert04 MSeifert04 mentioned this issue Mar 14, 2020
Merged
This was referenced Mar 16, 2020
Closed
Merged
@pllim
Copy link
Member Author

pllim commented Mar 16, 2020

In fiddling with #10038, I also found that pytest 5.4.1 to be incompatible with pytest-xdist, causing the 32-bit/parallel job to fail. See pytest-dev/pytest#6925

@pllim pllim added the 🔥 Critical label Mar 16, 2020
@Cadair Cadair mentioned this issue Mar 17, 2020
Merged
@bsipocz
Copy link
Member

bsipocz commented Mar 19, 2020

Workaround has been merged, and we have an upstream issue opened, so I'm closing this now.

@bsipocz bsipocz closed this as completed Mar 19, 2020
@pllim
Copy link
Member Author

pllim commented Mar 19, 2020

Thank you, all!

@dstansby
Copy link
Contributor

I'm struggling to follow the chain here, does anyone know what the workaround was that was merged (or the PR it was in?) I'm running onto this same issue in sunpy.

@bsipocz
Copy link
Member

bsipocz commented Mar 27, 2020

look at how the pin file (that is hosted in ci-helpers is used in tox.ini)

@bsipocz bsipocz mentioned this issue May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🔥 Critical testing Upstream Fix Required
Projects
None yet
Milestone
No milestone
3 participants
@pllim @dstansby @bsipocz