Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force zero warnings in test suite #3648

Merged
merged 8 commits into from Aug 6, 2020
Merged

Force zero warnings in test suite #3648

merged 8 commits into from Aug 6, 2020
+14 −3

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jan 6, 2020

It would be great to consciously make sure the right warnings are being thrown in the right places, so lets try turning them all into errors! The test suite will probably 💥 , but I might leave this PR to keep chipping away at the warnings in the hope of one day squashing them all.

@dstansby dstansby added the Tests Affects tests in some measure label Jan 6, 2020
@dstansby dstansby added this to the 2.0 milestone Jan 6, 2020
@ghost
Copy link

ghost commented Jan 6, 2020

Thanks for the pull request @dstansby!

I am a bot that checks pull requests for milestones and changelog entries. If you have any questions about what I am saying, please ask!
I have the following to report on this pull request:

  • I didn't detect a changelog file in this pull request. Please add a changelog file to the changelog/ directory following the instructions in the changelog README.

If there are any issues with this message, please report them here.

2 similar comments
@ghost
Copy link

ghost commented Jan 6, 2020

Thanks for the pull request @dstansby!

I am a bot that checks pull requests for milestones and changelog entries. If you have any questions about what I am saying, please ask!
I have the following to report on this pull request:

  • I didn't detect a changelog file in this pull request. Please add a changelog file to the changelog/ directory following the instructions in the changelog README.

If there are any issues with this message, please report them here.

@ghost
Copy link

ghost commented Jan 6, 2020

Thanks for the pull request @dstansby!

I am a bot that checks pull requests for milestones and changelog entries. If you have any questions about what I am saying, please ask!
I have the following to report on this pull request:

  • I didn't detect a changelog file in this pull request. Please add a changelog file to the changelog/ directory following the instructions in the changelog README.

If there are any issues with this message, please report them here.

@pep8speaks
Copy link

pep8speaks commented Jan 7, 2020 •
edited

Hello @dstansby! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-06 10:15:22 UTC

@dstansby dstansby added the [WIP] label Jan 8, 2020
@dstansby dstansby mentioned this pull request Jan 8, 2020
Merged
@dstansby dstansby requested review from a team as code owners January 9, 2020 17:55
@dstansby dstansby requested a review from a team as a code owner January 10, 2020 10:47
@dstansby dstansby requested a review from a team as a code owner January 13, 2020 15:57
@dstansby dstansby force-pushed the no-warnings branch 2 times, most recently from abc1c0a to 0afb6e1 Compare January 17, 2020 18:49
@dstansby dstansby requested a review from a team as a code owner January 17, 2020 20:59
@dstansby dstansby mentioned this pull request Jan 21, 2020
Merged
@dstansby dstansby mentioned this pull request Jan 31, 2020
Merged
@dstansby dstansby mentioned this pull request Feb 5, 2020
Merged
@dstansby dstansby requested a review from a team as a code owner February 16, 2020 20:52
@dstansby dstansby requested a review from a team as a code owner February 16, 2020 21:02
@dstansby dstansby force-pushed the no-warnings branch 2 times, most recently from afebc0e to 9ed7f61 Compare July 30, 2020 10:34
@dstansby dstansby force-pushed the no-warnings branch 2 times, most recently from 2b20cbb to 2a2f7b4 Compare July 31, 2020 10:04
@nabobalis nabobalis removed request for a team August 6, 2020 10:35
@nabobalis nabobalis removed the [WIP] label Aug 6, 2020
@nabobalis nabobalis changed the title [WIP] Force zero warnings in test suite Force zero warnings in test suite Aug 6, 2020
@nabobalis nabobalis merged commit a6c4235 into sunpy:master Aug 6, 2020
@dstansby dstansby deleted the no-warnings branch August 6, 2020 10:37
@Cadair
Copy link
Member

Cadair commented Aug 6, 2020

Thanks for all your work on this quest @dstansby 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadair Cadair Cadair left review comments

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
No Changelog Entry Needed Tests Affects tests in some measure
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dstansby @pep8speaks @nabobalis @Cadair