MNT: Update expat 2.2.9 #10038
MNT: Update expat 2.2.9 #10038
Conversation
pllim
added
the
external
|
Travis CI and mpldev failures caused by scientific-python/pytest-doctestplus#94 |
This comment has been minimized.
This comment has been minimized.
|
I had the same issue ;), you need to revert some changes in expat_config.h: |
| --with-getrandom | ||
| --without-getrandom | ||
| --with-sys-getrandom | ||
| --without-sys-getrandom |
There was a problem hiding this comment.
Using these new options with ./configure would simplify the update process.
There was a problem hiding this comment.
Which one is the correct option? 馃槅
There was a problem hiding this comment.
I think both --without-getrandom and --without-sys-getrandom, you can check the diff on expat_config.h.
| Other changes: | ||
| #299 #302 Windows: Replace LoadLibrary hack to access | ||
| unofficial API function SystemFunction036 (RtlGenRandom) | ||
| by using official API function rand_s (needs WinXP+) |
There was a problem hiding this comment.
This is also interesting since I had to include loadlibrary.c for windows:
ef5b44e
There was a problem hiding this comment.
Hmm. Does that mean I can remove what you added to setup_package.py?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@pllim - I leave the rebase to you here. |
|
@saimn , tests passed. Are you okay with this? Thanks for reviewing! |
Description
This pull request is to update bundled expat to 2.2.9. It is used in
astropy.utils.xmlfor parsing of VO table.@saimn , since you updated it the last time in #8343, can you please have a look to make sure I didn't mess anything up? 馃檱鈥嶁檧