Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Pin pytest<5.4 due to doctestplus #10044

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Member

@pllim pllim commented Mar 16, 2020

Description

This pull request is to address deprecation warning from pytest>=5.4 in pytest-doctestplus plugin causing failure in CI.

Fixes #10039

A version of #10040 for >=4.1

Based on astropy/ci-helpers#429 but our Linux CIs don't use ci-helpers.

@pllim pllim added this to the v4.0.1 milestone Mar 16, 2020
@pllim pllim requested review from bsipocz and astrofrog March 16, 2020 14:13
@pllim pllim modified the milestones: v4.0.1, v4.1 Mar 16, 2020
@pllim pllim force-pushed the pin-pytest-lt-5.4 branch 4 times, most recently from 1aed9e3 to fa34d73 Compare March 16, 2020 15:05
@pllim
Copy link
Member Author

pllim commented Mar 16, 2020

I just cannot get it to work. 🤷‍♀ p.s. Cancelled CircleCI because that is irrelevant here.

@pllim
Copy link
Member Author

pllim commented Mar 16, 2020

@astrofrog said he is going to submit his version of this fix, by re-introducing ci-helpers for Linux jobs.

@pllim pllim closed this Mar 16, 2020
@pllim pllim deleted the pin-pytest-lt-5.4 branch March 16, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: CI failures with pytest 5.4.0
1 participant