drop [Serializable] from exceptions #762
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Refactoring
PR Summary: The pull request removes the Serializable attribute from the ApprovalException class and its derived classes, ApprovalMismatchException and ApprovalMissingException. It also refactors the constructors to directly initialize the Received and Approved properties, enforcing immutability.
Decision: Comment
📝 Type: 'Refactoring' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the removal of serialization capabilities is clearly communicated to consumers of the library, as it may be a breaking change for those who rely on exception serialization.
- Verify that the new immutability of the Received and Approved properties aligns with the overall design philosophy of the project and does not introduce any unintended side effects.
- Consider the broader impact of these changes on the codebase, particularly if there are any existing mechanisms or features that depend on the serialization of these exceptions.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| namespace ApprovalTests.Core.Exceptions; | ||
|
|
||
| [Serializable] | ||
| public class ApprovalException : Exception | ||
| public class ApprovalException(string received, string approved) : Exception |
There was a problem hiding this comment.
suggestion (llm): The constructor now initializes the properties directly, which is a cleaner approach. However, ensure that this change is consistent with the overall design philosophy of the project, especially if immutability of these properties was not a design goal previously.
No description provided.