Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop [Serializable] from exceptions #762

Merged
merged 2 commits into from
Jan 23, 2024
Merged

drop [Serializable] from exceptions #762

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba88570
drop [Serializable] from exceptions
SimonCropp Jan 22, 2024
7797197
drop [Serializable] from exceptions
SimonCropp Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 3 additions & 26 deletions src/ApprovalTests/Core/Exceptions/ApprovalException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,10 @@
using System.Runtime.Serialization;

namespace ApprovalTests.Core.Exceptions;

[Serializable]
public class ApprovalException : Exception
public class ApprovalException(string received, string approved) : Exception
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): The constructor now initializes the properties directly, which is a cleaner approach. However, ensure that this change is consistent with the overall design philosophy of the project, especially if immutability of these properties was not a design goal previously.

public ApprovalException(SerializationInfo info, StreamingContext context) : base(info, context)
{
Approved = info.GetString("Approved");
Received = info.GetString("Received");
}

public ApprovalException(string received, string approved)
{
Received = received;
Approved = approved;
}
public string Received { get; } = received;

public string Received { get; }

public string Approved { get; }
public string Approved { get; } = approved;

protected bool Equals(ApprovalException other) => string.Equals(Approved, other.Approved) && string.Equals(Received, other.Received);

Expand All @@ -42,12 +27,4 @@ public override int GetHashCode()
public static bool operator ==(ApprovalException left, ApprovalException right) => Equals(left, right);

public static bool operator !=(ApprovalException left, ApprovalException right) => !Equals(left, right);

public override void GetObjectData(SerializationInfo info, StreamingContext context)
{
base.GetObjectData(info, context);

info.AddValue("Approved", Approved);
info.AddValue("Received", Received);
}
}
15 changes: 2 additions & 13 deletions src/ApprovalTests/Core/Exceptions/ApprovalMismatchException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,7 @@
using System.Runtime.Serialization;

namespace ApprovalTests.Core.Exceptions;

[Serializable]
public class ApprovalMismatchException : ApprovalException
public class ApprovalMismatchException(string received, string approved) :
ApprovalException(received, approved)
{
public ApprovalMismatchException(SerializationInfo info, StreamingContext context)
: base(info, context)
{
}

public ApprovalMismatchException(string received, string approved) : base(received, approved)
{
}

public override string Message => $"Failed Approval: Received file {Received} does not match approved file {Approved}.";
}
14 changes: 2 additions & 12 deletions src/ApprovalTests/Core/Exceptions/ApprovalMissingException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,7 @@
using System.Runtime.Serialization;

namespace ApprovalTests.Core.Exceptions;

[Serializable]
public class ApprovalMissingException : ApprovalException
public class ApprovalMissingException(string received, string approved) :
ApprovalException(received, approved)
{
public ApprovalMissingException(SerializationInfo info, StreamingContext context) : base(info, context)
{
}

public ApprovalMissingException(string received, string approved) : base(received, approved)
{
}

public override string Message => $"Failed Approval: Approval File \"{Approved}\" Not Found.";
}