drop [Serializable] from exceptions (#762)

* drop [Serializable] from exceptions * drop [Serializable] from exceptions
approvals · Jan 23, 2024 · 9e481b4 · 9e481b4
1 parent aaab5b4
commit 9e481b4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 72 deletions.
diff --git a/src/ApprovalTests.Tests/Core/SerializableExceptionsTest.cs b/src/ApprovalTests.Tests/Core/SerializableExceptionsTest.cs
diff --git a/src/ApprovalTests/Core/Exceptions/ApprovalException.cs b/src/ApprovalTests/Core/Exceptions/ApprovalException.cs
@@ -1,25 +1,10 @@
-using System.Runtime.Serialization;
-
 namespace ApprovalTests.Core.Exceptions;
 
-[Serializable]
-public class ApprovalException : Exception
+public class ApprovalException(string received, string approved) : Exception
 {
-    public ApprovalException(SerializationInfo info, StreamingContext context) : base(info, context)
-    {
-        Approved = info.GetString("Approved");
-        Received = info.GetString("Received");
-    }
-
-    public ApprovalException(string received, string approved)
-    {
-        Received = received;
-        Approved = approved;
-    }
+    public string Received { get; } = received;
 
-    public string Received { get; }
-
-    public string Approved { get; }
+    public string Approved { get; } = approved;
 
     protected bool Equals(ApprovalException other) => string.Equals(Approved, other.Approved) && string.Equals(Received, other.Received);
 
@@ -42,12 +27,4 @@ public override int GetHashCode()
     public static bool operator ==(ApprovalException left, ApprovalException right) => Equals(left, right);
 
     public static bool operator !=(ApprovalException left, ApprovalException right) => !Equals(left, right);
-
-    public override void GetObjectData(SerializationInfo info, StreamingContext context)
-    {
-        base.GetObjectData(info, context);
-
-        info.AddValue("Approved", Approved);
-        info.AddValue("Received", Received);
-    }
 }
diff --git a/src/ApprovalTests/Core/Exceptions/ApprovalMismatchException.cs b/src/ApprovalTests/Core/Exceptions/ApprovalMismatchException.cs
@@ -1,18 +1,7 @@
-using System.Runtime.Serialization;
-
 namespace ApprovalTests.Core.Exceptions;
 
-[Serializable]
-public class ApprovalMismatchException : ApprovalException
+public class ApprovalMismatchException(string received, string approved) :
+    ApprovalException(received, approved)
 {
-    public ApprovalMismatchException(SerializationInfo info, StreamingContext context)
-        : base(info, context)
-    {
-    }
-
-    public ApprovalMismatchException(string received, string approved) : base(received, approved)
-    {
-    }
-
     public override string Message => $"Failed Approval: Received file {Received} does not match approved file {Approved}.";
 }
diff --git a/src/ApprovalTests/Core/Exceptions/ApprovalMissingException.cs b/src/ApprovalTests/Core/Exceptions/ApprovalMissingException.cs
@@ -1,17 +1,7 @@
-using System.Runtime.Serialization;
-
 namespace ApprovalTests.Core.Exceptions;
 
-[Serializable]
-public class ApprovalMissingException : ApprovalException
+public class ApprovalMissingException(string received, string approved) :
+    ApprovalException(received, approved)
 {
-    public ApprovalMissingException(SerializationInfo info, StreamingContext context) : base(info, context)
-    {
-    }
-
-    public ApprovalMissingException(string received, string approved) : base(received, approved)
-    {
-    }
-
     public override string Message => $"Failed Approval: Approval File \"{Approved}\" Not Found.";
 }