fix(migrations): add migration to replace /deep/ with ::ng-deep
#42214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
With this change we add a migration to replace the deprecated shadow-piercing selector from `/deep/` with deprecated but recommended `::ng-deep`. The main motivation for this change is that the CSS optimizer CSSNano which is used by the Angular CLI no longer supports this non standard selector and causes build time errors due to the selector being minified incorrectly. However, CSSNano does support the recommended deprecated `::ng-deep` selector. Closes: #42196
devversion
reviewed
May 21, 2021
packages/core/schematics/migrations/deep-shadow-piercing-selector/index.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/migrations/deep-shadow-piercing-selector/index.ts
Outdated
Show resolved
Hide resolved
devversion
approved these changes
May 21, 2021
There was a problem hiding this comment.
LGTM. I think there are edge-cases where this migration would incorrectly change code. e.g. consider a path like my_server/deep/whatever. Though this is unlikely and it's better to keep the migration simple IMO.
Edit: As Alan pointed out the example above is not a good one. Though as said, there can be edge-cases with a trailing space too
|
@devversion I added the trailing space in the check ie |
alan-agius4
added
action: merge
zarend
pushed a commit
that referenced
this pull request
May 21, 2021
…42214) With this change we add a migration to replace the deprecated shadow-piercing selector from `/deep/` with deprecated but recommended `::ng-deep`. The main motivation for this change is that the CSS optimizer CSSNano which is used by the Angular CLI no longer supports this non standard selector and causes build time errors due to the selector being minified incorrectly. However, CSSNano does support the recommended deprecated `::ng-deep` selector. Closes: #42196 PR Close #42214
iRealNirmal
pushed a commit
to iRealNirmal/angular
that referenced
this pull request
Jun 4, 2021
…ngular#42214) With this change we add a migration to replace the deprecated shadow-piercing selector from `/deep/` with deprecated but recommended `::ng-deep`. The main motivation for this change is that the CSS optimizer CSSNano which is used by the Angular CLI no longer supports this non standard selector and causes build time errors due to the selector being minified incorrectly. However, CSSNano does support the recommended deprecated `::ng-deep` selector. Closes: angular#42196 PR Close angular#42214
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we add a migration to replace the deprecated shadow-piercing selector from
/deep/with deprecated but recommended::ng-deep.The main motivation for this change is that the CSS optimizer CSSNano which is used by the Angular CLI no longer supports this non standard selector and causes build time errors due to the selector being minified incorrectly. However, CSSNano does support the recommended deprecated
::ng-deepselector.Closes: #42196