Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StylePreproccessor error with /deep/ in css #1990

Closed
fnnzzz opened this issue May 26, 2021 · 5 comments
Closed

StylePreproccessor error with /deep/ in css #1990

fnnzzz opened this issue May 26, 2021 · 5 comments

Comments

@fnnzzz
Copy link

fnnzzz commented May 26, 2021

Type of Issue

[x] Bug Report
[ ] Feature Request

Description

I'm getting an error on some css with a error message Unclosed comment in stylesheet file
CSS looks like this

image

I suspect the preprocessor is treating /deep/ as an unclosed comment. (if you delete it, then everything works correctly)

How To Reproduce

  • add to css /deep/ and run build

Version Information

ng-packagr: 12.0.2
"@angular/animations": "12.0.1",
"@angular/cdk": "^12.0.1",
"@angular/common": "12.0.1",
"@angular/compiler": "12.0.1",
"@angular/core": "12.0.1",
"@angular/elements": "12.0.1",
"@angular/fire": "^6.1.5",
"@angular/forms": "12.0.1",
"@angular/material": "^12.0.1",
"@angular/material-moment-adapter": "^12.0.1",
"@angular/platform-browser": "12.0.1",
"@angular/platform-browser-dynamic": "12.0.1",
"@angular/platform-server": "^12.0.1",
"@angular/router": "12.0.1",
typescript: 4.2.4
rxjs: 7.0.1
node: 14.16.1
yarn: 1.22.5
@fnnzzz fnnzzz changed the title StylePreproccessor error with /deep/ StylePreproccessor error with /deep/ in css May 26, 2021
@fnnzzz
Copy link
Author

fnnzzz commented May 26, 2021

After changed /deep to ::ng-deep a build passed.

https://angular.io/guide/component-styles

The /deep/ combinator also has the aliases >>>, and ::ng-deep.

@fnnzzz
Copy link
Author

fnnzzz commented May 26, 2021

UPD:
angular/angular#42214
I noticed that the angular team is preparing a migration for /deep/, so maybe it's just a matter of time

@SchnWalter
Copy link
Contributor

Actually, both versions are deprecated: https://angular.io/guide/deprecations#deep-component-style-selector and should be avoided.

@alan-agius4
Copy link
Member

Closing since /deep/ is no longer supported by the underlying tooling.

Please use ::ng-deep instead.

@github-actions
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants