Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migrations): add migration to replace /deep/ with ::ng-deep #42214

Closed
wants to merge 3 commits into from
Closed

fix(migrations): add migration to replace /deep/ with ::ng-deep #42214

wants to merge 3 commits into from

Commits on May 21, 2021

  1. fix(migrations): add migration to replace /deep/ with ::ng-deep 

    With this change we add a migration to replace the deprecated shadow-piercing selector from `/deep/` with deprecated but recommended `::ng-deep`.

The main motivation for this change is that the CSS optimizer CSSNano which is used by the Angular CLI no longer supports this non standard selector and causes build time errors due to the selector being minified incorrectly. However, CSSNano does support the recommended deprecated `::ng-deep` selector.

Closes: #42196
    @alan-agius4
    alan-agius4 committed May 21, 2021
    Copy the full SHA
    6a42e60 View commit details
    Browse the repository at this point in the history

  2. fixup! fix(migrations): add migration to replace /deep/ with `::ng-… 

    …deep`
    @alan-agius4
    alan-agius4 committed May 21, 2021
    Copy the full SHA
    f2fc2f1 View commit details
    Browse the repository at this point in the history

  3. fixup! fix(migrations): add migration to replace /deep/ with `::ng-… 

    …deep`
    @alan-agius4
    alan-agius4 committed May 21, 2021
    Copy the full SHA
    be9c4bf View commit details
    Browse the repository at this point in the history