-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): support computed base class in metadata inheritance #24014
Conversation
@@ -18,9 +18,9 @@ import {GetterFn, MethodFn, SetterFn} from './types'; | |||
* Attention: These regex has to hold even if the code is minified! | |||
*/ | |||
export const DELEGATE_CTOR = /^function\s+\S+\(\)\s*{[\s\S]+\.apply\(this,\s*arguments\)/; | |||
export const INHERITED_CLASS = /^class\s+[A-Za-z\d$_]*\s*extends\s+[A-Za-z\d$_]+\s*{/; | |||
export const INHERITED_CLASS = /^class\s+[A-Za-z\d$_]*\s*extends\s+[^{}]+\s*{/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't [^{]+
enough? Can a closing bracket be in that order? You shouldn't need the space after either, so basically this should be good enough: /^class\s+[A-Za-z\d$_]*\s*extends\s+[^{]+{/
45bb8cf
to
569ab11
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #22356 (comment)
What is the new behavior?
N/A.
Does this PR introduce a breaking change?
Other information
It's my bad in first place.