-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix: workaround for es2015 inheritance not always working (#1… #13868
Conversation
…gular#13834)" This reverts commit a22a9fa. This change caused a new issue where Closure Compiler was not able to do dead-code elimination due to the function call with unknown side effects.
@jelbourn Hmm going forward with this, I'm not sure if it's even worth keeping the workaround at all. The way it will be after the revert (without my new changes), it's practically not helping and just causes even more exceptions than before (in case the We definitely need to solve the Closure issue, and I can't think of a way to mark the function for inheriting as side effect free (google/closure-compiler#2256). That being said, we should probably remove the workaround completely and wait for Ivy. It's not an issue from Material, rather from Angular. |
Also considering that angular/angular#24014 is finally merge ready as well, it might be just the best to get rid of the workaround completely. I can update this PR if you don't find time for it. |
We need to revert it first to unblock syncing into Google and then we can explore other approaches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Should we chat on Slack about the final solution? I'd vote for removing.
@devversion yeah, let's discuss it in more detail |
…gular#13834)" (angular#13868) This reverts commit a22a9fa. This change caused a new issue where Closure Compiler was not able to do dead-code elimination due to the function call with unknown side effects.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…3834)"
This reverts commit a22a9fa.
This change caused a new issue where Closure Compiler was not able to do
dead-code elimination due to the function call with unknown side
effects.