Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): support computed base class in metadata inheritance #24014

Closed
wants to merge 1 commit into from
Closed

fix(core): support computed base class in metadata inheritance #24014

wants to merge 1 commit into from

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented May 20, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #22356 (comment)

What is the new behavior?

N/A.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

It's my bad in first place.

alfaproject
alfaproject reviewed May 20, 2018
View reviewed changes
packages/core/src/reflection/reflection_capabilities.ts Outdated
@@ -18,9 +18,9 @@ import {GetterFn, MethodFn, SetterFn} from './types';
* Attention: These regex has to hold even if the code is minified!
*/
export const DELEGATE_CTOR = /^function\s+\S+\(\)\s*{[\s\S]+\.apply\(this,\s*arguments\)/;
export const INHERITED_CLASS = /^class\s+[A-Za-z\d$_]*\s*extends\s+[A-Za-z\d$_]+\s*{/;
export const INHERITED_CLASS = /^class\s+[A-Za-z\d$_]*\s*extends\s+[^{}]+\s*{/;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't [^{]+ enough? Can a closing bracket be in that order? You shouldn't need the space after either, so basically this should be good enough: /^class\s+[A-Za-z\d$_]*\s*extends\s+[^{]+{/

@trotyl trotyl force-pushed the fix-metadata-inheritance-es2015 branch from 45bb8cf to 569ab11 Compare May 20, 2018 11:32
@trotyl trotyl mentioned this pull request May 28, 2018
Closed
3 tasks
@vicb vicb added the area: core Issues related to the framework runtime label May 31, 2018
@trotyl trotyl mentioned this pull request Jun 21, 2018
Closed
@trotyl trotyl mentioned this pull request Oct 16, 2018
Closed
@ngbot ngbot bot added this to the needsTriage milestone Oct 25, 2018
@mhevery mhevery self-assigned this Oct 25, 2018
@mhevery mhevery added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Oct 25, 2018
@mhevery
Copy link
Contributor

mhevery commented Oct 25, 2018

http://test/OCL:218761459:BASE:218761495:1540506709603:3536f4c7

@devversion devversion mentioned this pull request Oct 30, 2018
Merged
matsko pushed a commit that referenced this pull request Oct 30, 2018
@trotyl @matsko
fix(core): support computed base class in metadata inheritance (#24014)
b3c6409 
PR Close #24014
@matsko matsko closed this in 95743e3 Oct 30, 2018
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
@trotyl @sculove
fix(core): support computed base class in metadata inheritance (angul…
58add0a 
…ar#24014)

PR Close angular#24014
@trotyl trotyl deleted the fix-metadata-inheritance-es2015 branch November 17, 2018 16:09
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@trotyl @FrederikSchlemmer
fix(core): support computed base class in metadata inheritance (angul…
afd7fa1 
…ar#24014)

PR Close angular#24014
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfaproject alfaproject alfaproject left review comments

@mhevery mhevery mhevery approved these changes

Assignees

@mhevery mhevery

Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trotyl @mhevery @alfaproject @vicb @googlebot