New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ament_cmake_python_install() handle symlink installs. #325
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It would be great if someone else can also take a look too.
I will also test locally before ✔️
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
I would recommend running CI again with |
Just in case, it would be good to also test something that depends on |
Ok, Windows CI is failing because some hard-coded relative path in |
Alright, it's worst than I thought. There's a lot of packages that rely on Python sources (or a symlink to them) being present in the install space... I'll drop the environment hooks and do plain symlinks. It's not more of a hack than using these ad-hoc hooks. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is happy
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Argh... this is so fragile. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This patch is an abomination, but I don't know how to make things better. BTW there's also an |
This doesn't work either... I'm starting to consider rolling back and simply dropping a flat egg in the install space. It's a hack, but Python's packaging ecosystem is not cooperating. |
Superseded by #326. |
Precisely what the title says. Yet another regression after #316, though this one turned into a rabbit hole.
colcon
handles Python packages in a very peculiar way, so this patch replicates as much as necessary intoament_cmake_python
.Full CI, just to be sure: