Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ament_cmake_python_install() handle symlink installs. #325

Closed
wants to merge 6 commits into from
Closed

Make ament_cmake_python_install() handle symlink installs. #325

wants to merge 6 commits into from

Commits on Mar 4, 2021

  1. Make ament_cmake_python_install() handle symlink installs. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    988100d View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Prevent Windows native path escaping 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    1e0f464 View commit details
    Browse the repository at this point in the history

  2. Address peer review comments 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    f14c59b View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Add symlink to sources at install dir 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    d173dab View commit details
    Browse the repository at this point in the history

  2. Fix (but detect) failing setup.py commands 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    d10a85b View commit details
    Browse the repository at this point in the history

  3. Symlink source files one by one 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    f5f9768 View commit details
    Browse the repository at this point in the history