-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify ament_python_install_package() macro. #326
Conversation
Do not delegate to setuptools, install egg-info manually. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me
Alright, CI is green, reviewer's happy. Going in ! |
@@ -4,31 +4,6 @@ project(ament_cmake_python NONE) | |||
|
|||
find_package(ament_cmake_core REQUIRED) | |||
|
|||
set(ament_cmake_python_DIR "${CMAKE_CURRENT_SOURCE_DIR}/cmake") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap. I'll send a PR.
Follow-up after #326. Should've been removed then. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Follow-up after #326. Should've been removed then. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic It seems this PR breaks ability to create Python subpackages. Before (in Foxy) I was able to: ament_python_install_package(${PROJECT_NAME}/subpackage
PACKAGE_DIR src/mypackage) and it would create a subpackage. In Rolling it shows the following error:
Is there a workaround or it is broken on purpose? |
IIRC the first argument was always expected to be a package name, which shouldn't contain any If you have many package you can still use |
Alternative to #316, #323, #324, #325. This patch no longer delegates to
setuptools
, it simply builds and installs an.egg-info
directory manually. It's a bit hacky, but it's less fragile than the original approach.CI up to
test_communication
(to exerciserclpy
androsidl
packages):CI up to
test_communication
with--symlink-install
: