Bump kaminari from 1.1.1 to 1.2.0

[dependabot-preview]

Bumps kaminari from 1.1.1 to 1.2.0.

Changelog

Sourced from kaminari's changelog.

1.2.0

Deprecations:

• Deprecated current_per_page in favor of limit_value

Enhancements:

• Added #url_to_next_page and #url_to_prev_page helper methods: 38e95a2
• Extracted url helper methods and packed them in Kaminari::Helpers::UrlHelper: ff38bee
• Improved performance of total_count for grouped queries by explicitly giving SQL select clause #979 [@MmKolodziej]
• Added LIMIT to total_count query when max_pages presents #981 [@rymai]

Bug Fixes:

• Fixed a bug where the kaminari-mongoid gem was not loaded properly: kaminari/kaminari-mongoid#9 [@DenniJensen]
• Fixed a bug where the #total_count method incorrectly calculates the total count: #932 [@tumayun]
• Fixed a bug where empty? breaks subsequent last_page? in without_count mode #1009 [@montdidier]
• Fixed kwargs warnings on Ruby 2.7 #1010 [@connorshea]

Commits

• a2f262e Actually, let's call it 1.2.0
• f901ad4 Version 1.1.2
• c3114fa Changes for version 1.1.2
• b21c1da using has to be called from the toplevel in Ruby 2.0
• 795b2b7 Let this plugin internal method be super private within this file
• 5430227 This seems untrue now...
• 98d0d8c Give it a proper name
• fb3904f Simplify the logic by not repeating the same conditions twice
• 0f1b9a8 DRY
• c22acef private methods
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Pull request limits (per update run and/or open at any time)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

[ChrisBAshton]

Multiple failures in test/unit/admin/statistics_announcement_filter_test.rb. Example:

$ govuk-docker-run bundle exec bin/rails test test/unit/admin/statistics_announcement_filter_test.rb:131

Error:
Admin::StatisticsAnnouncementFilterTest#test_#description_describes_future_statistics_announcements:
ActiveRecord::StatementInvalid: Mysql2::Error: Unknown column 'statistics_announcements.publishing_state' in 'where clause': SELECT COUNT(*) FROM (SELECT 1 FROM `statistics_announcements` INNER JOIN statistics_announcement_dates
                              ON (statistics_announcement_dates.statistics_announcement_id = statistics_announcements.id) LEFT OUTER JOIN statistics_announcement_dates sd2
                              ON (sd2.statistics_announcement_id = statistics_announcements.id
                              AND statistics_announcement_dates.created_at > sd2.created_at) WHERE `statistics_announcements`.`publishing_state` = 'published' AND (statistics_announcement_dates.release_date > '2011-11-11 11:11:11') GROUP BY statistics_announcement_dates.statistics_announcement_id) subquery WHERE `statistics_announcements`.`publishing_state` = 'published'
    app/models/admin/statistics_announcement_filter.rb:30:in `total_count'
    app/models/admin/statistics_announcement_filter.rb:58:in `pluralized_count'
    app/models/admin/statistics_announcement_filter.rb:64:in `date_based_description'
    app/models/admin/statistics_announcement_filter.rb:26:in `description'
    test/unit/admin/statistics_announcement_filter_test.rb:135:in `block in <class:StatisticsAnnouncementFilterTest>'

Looks like this open PR will fix it: kaminari/kaminari#1012

Verified by changing this line in our Gemfile:

gem "kaminari", git: "https://github.com/misoca/kaminari", ref: "fix-total-count-when-model-has-default-scope"

All tests pass:

$ govuk-docker-run bundle exec bin/rails test 
# Running:

..................

Finished in 11.250818s, 1.5999 runs/s, 2.3998 assertions/s.
18 runs, 27 assertions, 0 failures, 0 errors, 0 skips

[kevindew]

👏 for leaving notes

[ChrisBAshton]

The offending PR has been reverted, but still awaiting a release to rubygems.

[ChrisBAshton]

I've asked for an update: kaminari/kaminari#979 (comment)

[benthorner]

This should be fixed soon: kaminari/kaminari#979 (comment)

[dependabot-preview]

Superseded by #5636.