Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.7 deprecation warning #1010

Closed
connorshea opened this issue Dec 27, 2019 · 10 comments
Closed

Ruby 2.7 deprecation warning #1010

connorshea opened this issue Dec 27, 2019 · 10 comments
Labels

Comments

@connorshea
Copy link

/Users/connorshea/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/kaminari-core-1.1.1/lib/kaminari/helpers/helper_methods.rb:25: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/connorshea/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/kaminari-core-1.1.1/lib/kaminari/helpers/paginator.rb:9: warning: The called method `initialize' is defined here

I assume this can be fixed by replacing paginator = paginator_class.new (template || self), options with paginator = paginator_class.new (template || self), **options? The current master has changed that file a lot, but it still has the same line (now at 115).

@connorshea
Copy link
Author

It also seems like the ruby-head builds are failing in CI. I think it may require updating RubyGems, or just re-running it since 2.7 should include the latest RubyGems release.

@yuki24
Copy link
Member

yuki24 commented Dec 27, 2019

Thanks for reporting. I'm hoping that we will be able to fix this in the coming weeks.

@amatsuda
Copy link
Member

@connorshea Thank you for letting us know! I just pushed 011d6ac that addresses the warnings that I saw while I run the tests locally.
I'm still not 100% confident that we fixed all kwargs related warnings, but we'll cut a new release as soon as we finish checking all suspicious method calls.

@connorshea
Copy link
Author

@yuki24 @amatsuda great, thank you! :)

@connorshea
Copy link
Author

Any news on the new release? :)

@amatsuda
Copy link
Member

@connorshea Pushed 1.2.0 gem with a fix for this issue. Thank you for waiting patiently! :)

@connorshea
Copy link
Author

Thanks!

@wilpar
Copy link

wilpar commented Mar 21, 2020

Confirmed I'm at 1.20, but I'm still getting a deprecation warning for line 130:

/gems/ruby-2.7.0/gems/kaminari-core-1.2.0/lib/generators/kaminari/views_generator.rb:130: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open

@yuki24
Copy link
Member

yuki24 commented Mar 23, 2020

@wilpar Good catch! we probably missed it since it's in the generator. It would be greatly appreciated if you could send us a pull request.

@wilpar
Copy link

wilpar commented Mar 25, 2020

if i can figure it out, i most certainly will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants