New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 2.7 deprecation warning #1010
Comments
It also seems like the ruby-head builds are failing in CI. I think it may require updating RubyGems, or just re-running it since 2.7 should include the latest RubyGems release. |
Thanks for reporting. I'm hoping that we will be able to fix this in the coming weeks. |
@connorshea Thank you for letting us know! I just pushed 011d6ac that addresses the warnings that I saw while I run the tests locally. |
Any news on the new release? :) |
@connorshea Pushed 1.2.0 gem with a fix for this issue. Thank you for waiting patiently! :) |
Thanks! |
Confirmed I'm at 1.20, but I'm still getting a deprecation warning for line 130:
|
@wilpar Good catch! we probably missed it since it's in the generator. It would be greatly appreciated if you could send us a pull request. |
if i can figure it out, i most certainly will. |
lib/kaminari/helpers/helper_methods.rb:25
lib/kaminari/helpers/paginator.rb:9
I assume this can be fixed by replacing
paginator = paginator_class.new (template || self), options
withpaginator = paginator_class.new (template || self), **options
? The current master has changed that file a lot, but it still has the same line (now at 115).The text was updated successfully, but these errors were encountered: