fixes without_count last_page? behaviour #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It would greatly be appreciated if you could add a test and fix the builds for Rails 4.2 and 4.1. We still do support them and we don't drop support for older versions unless it is extremely difficult. |
|
I just wanted to check in and see if you are still interested in updating the pull request.
|
|
@yuki24 Yes I will fix this. I've just not had a chance to revisit it yet. |
|
@yuki24 Should be fixed . |
|
Could you add tests? Regression tests are extremely important. |
yuki24
reviewed
Dec 23, 2019
kaminari-activerecord/lib/kaminari/activerecord/active_record_relation_methods.rb
Outdated
Show resolved
Hide resolved
|
@montdidier Thank you for your contribution! really appreciated. |
amatsuda
added a commit
that referenced
this pull request
Jan 21, 2020
because it's not explained in the PR, and I couldn't reproduce the behavior locally #1009
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this will fix this bug.
After some experimentation I noted that
@arel.limitis not always anInteger. In the cases this code fails to perform as expected this type isArel::Nodes::BindParam. After some inspection of the various types it appears to me this additional type can also be cloned and modified to behave as expected.