Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to rubocop 0.76 #163

Merged
merged 18 commits into from Nov 13, 2019
Merged

Update to rubocop 0.76 #163

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cacb774
bump gem versions, add new gems that have been spun out
Nov 9, 2019
72066c1
require new gems in config file
Nov 9, 2019
9d2dd27
fix ruby compilation
Nov 9, 2019
72bfac7
migrate cop names
Nov 9, 2019
784a4c8
remove duplicate rule
Nov 9, 2019
1421a32
move flip flop to correct file
Nov 9, 2019
2bfe2db
transfer cops from performance.yml to style.yml
Nov 9, 2019
b0a5edf
don't freeze since file has frozen string comment
Nov 9, 2019
4a190d2
remove 2.2 from CI, add 2.6
Nov 9, 2019
7a94864
add Rails/IgnoredSkipActionFilterOption cop
Nov 9, 2019
5493a81
Remove Airbnb/ClassName cop, since that functionality is now included…
Nov 9, 2019
81df175
Disable Naming/RescuedExceptionsVariableName
Nov 9, 2019
cb67d63
add Layout/IndentFirstParameter cop
Nov 9, 2019
cb8d599
explicitly enable Gemspec/RubyVersionGlobalsUsage
Nov 9, 2019
c04fccf
show supported styles
Nov 13, 2019
944aac1
bump version
Nov 13, 2019
4591307
update changelog and readme
Nov 13, 2019
39f16ea
add comma to readme
Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions rubocop-airbnb/config/rubocop-airbnb.yml
View file
Open in desktop
Expand Up @@ -2,11 +2,6 @@
# They are custom built for use inside Airbnb and address issues that we have experienced in
# testing and production.

Airbnb/ClassName:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably delete class_name.rb and class_name_spec.rb now that we're using Rubocop's ReflectionClassName cop instead.

Description: Use :class_name => "Model" instead of :class_name => Model.name
to avoid a long cascade of autoloading.
Enabled: true

Airbnb/ClassOrModuleDeclaredInWrongFile:
Description: Declare a class or module in the file that matches its namespace and name.
Enabled: true
Expand Down
3 changes: 3 additions & 0 deletions rubocop-airbnb/config/rubocop-rails.yml
View file
Open in desktop
Expand Up @@ -209,3 +209,6 @@ Rails/Validation:

Rails/IgnoredSkipActionFilterOption:
Enabled: true

Rails/ReflectionClassName:
Enabled: true
47 changes: 0 additions & 47 deletions rubocop-airbnb/lib/rubocop/cop/airbnb/class_name.rb
View file
Open in desktop

This file was deleted.

78 changes: 0 additions & 78 deletions rubocop-airbnb/spec/rubocop/cop/airbnb/class_name_spec.rb
View file
Open in desktop

This file was deleted.