New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to rubocop 0.76 #163
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cacb774
bump gem versions, add new gems that have been spun out
72066c1
require new gems in config file
9d2dd27
fix ruby compilation
72bfac7
migrate cop names
784a4c8
remove duplicate rule
1421a32
move flip flop to correct file
2bfe2db
transfer cops from performance.yml to style.yml
b0a5edf
don't freeze since file has frozen string comment
4a190d2
remove 2.2 from CI, add 2.6
7a94864
add Rails/IgnoredSkipActionFilterOption cop
5493a81
Remove Airbnb/ClassName cop, since that functionality is now included…
81df175
Disable Naming/RescuedExceptionsVariableName
cb67d63
add Layout/IndentFirstParameter cop
cb8d599
explicitly enable Gemspec/RubyVersionGlobalsUsage
c04fccf
show supported styles
944aac1
bump version
4591307
update changelog and readme
39f16ea
add comma to readme
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is enabled by default -- is it worth explicitly enabling here or should we just use the rubocop default settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's explicitly enable it here for clarity. I don't know where the Rubocop defaults are set but I see tons of enabled cops in our configs that are probably also enabled by default.