Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PEP 517 build system #746

Merged
merged 1 commit into from Mar 25, 2022
Merged

Migrate to PEP 517 build system #746

merged 1 commit into from Mar 25, 2022

Conversation

Nothing4You
Copy link
Collaborator

What do these changes do?

Migrate to PEP 517 build system

  • all remaining setuptools configuration is moved from setup.py to setup.cfg
  • description is now checked with twine rather than setup.py check

Are there changes in behavior for the user?

no

Related issue number

split from #734

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into CHANGES.txt

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #746 (7abaec6) into master (c8a4334) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files          35       35           
  Lines        5533     5533           
  Branches      941      941           
=======================================
  Hits         5138     5138           
  Misses        307      307           
  Partials       88       88           
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.2 89.39% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.3 89.39% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.4 89.39% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.5 89.37% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.6 89.37% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.7 89.37% <ø> (ø)
ubuntu-latest_3.10_mysql-5.7 90.07% <ø> (ø)
ubuntu-latest_3.10_mysql-8.0 91.46% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.2 89.35% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.3 89.35% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.4 89.35% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.5 89.33% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.6 89.33% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.7 89.33% <ø> (ø)
ubuntu-latest_3.11-dev_mysql-5.7 90.04% <ø> (ø)
ubuntu-latest_3.11-dev_mysql-8.0 91.43% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.2 88.79% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.3 88.79% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.4 88.79% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.5 88.77% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.6 88.77% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.7 88.77% <ø> (ø)
ubuntu-latest_3.7_mysql-5.7 89.52% <ø> (ø)
ubuntu-latest_3.7_mysql-8.0 91.00% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.2 89.43% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.3 89.43% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.4 89.43% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.5 89.41% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.6 89.41% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.7 89.41% <ø> (ø)
ubuntu-latest_3.8_mysql-5.7 90.11% <ø> (ø)
ubuntu-latest_3.8_mysql-8.0 91.49% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.2 89.28% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.3 89.28% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.4 89.28% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.5 89.26% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.6 89.26% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.7 89.26% <ø> (ø)
ubuntu-latest_3.9_mysql-5.7 89.97% <ø> (ø)
ubuntu-latest_3.9_mysql-8.0 91.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8a4334...7abaec6. Read the comment docs.

@lgtm-com

This comment was marked as outdated.

- all remaining setuptools configuration is moved from setup.py to setup.cfg
- description is now checked with twine rather than `setup.py check`

Split from #734, including suggestions from @webknjaz

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
@lgtm-com
Copy link

lgtm-com bot commented Mar 15, 2022

This pull request fixes 1 alert when merging 7abaec6 into c8a4334 - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary 'else' clause in loop

@Nothing4You Nothing4You merged commit 42532c8 into master Mar 25, 2022
@Nothing4You Nothing4You deleted the remove-setup.py branch March 25, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant