Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement release workflow in GitHub actions #734

Merged
merged 19 commits into from Apr 10, 2022
Merged

Implement release workflow in GitHub actions #734

merged 19 commits into from Apr 10, 2022

Conversation

Nothing4You
Copy link
Collaborator

@Nothing4You Nothing4You commented Feb 18, 2022

What do these changes do?

Are there changes in behavior for the user?

no

Related issue number

fixes #322

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment to CHANGES.txt

@Nothing4You Nothing4You added this to the 0.1 milestone Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #734 (fc09588) into master (f12aa64) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   92.83%   92.84%   +0.01%     
==========================================
  Files          36       38       +2     
  Lines        5537     5551      +14     
  Branches      941      941              
==========================================
+ Hits         5140     5154      +14     
  Misses        309      309              
  Partials       88       88              
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.2 89.38% <ø> (+0.02%) ⬆️
ubuntu-latest_3.10_mariadb-10.3 89.38% <ø> (+0.02%) ⬆️
ubuntu-latest_3.10_mariadb-10.4 89.38% <ø> (+0.02%) ⬆️
ubuntu-latest_3.10_mariadb-10.5 89.37% <ø> (+0.02%) ⬆️
ubuntu-latest_3.10_mariadb-10.6 89.37% <ø> (+0.02%) ⬆️
ubuntu-latest_3.10_mariadb-10.7 89.37% <ø> (+0.02%) ⬆️
ubuntu-latest_3.10_mysql-5.7 90.07% <ø> (+0.02%) ⬆️
ubuntu-latest_3.10_mysql-8.0 91.46% <ø> (+0.02%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.2 89.35% <ø> (+0.02%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.3 89.35% <ø> (+0.02%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.4 89.35% <ø> (+0.02%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.5 89.33% <ø> (+0.02%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.6 89.33% <ø> (+0.02%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.7 89.33% <ø> (+0.02%) ⬆️
ubuntu-latest_3.11-dev_mysql-5.7 90.03% <ø> (+0.02%) ⬆️
ubuntu-latest_3.11-dev_mysql-8.0 91.42% <ø> (+0.02%) ⬆️
ubuntu-latest_3.7_mariadb-10.2 88.79% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.3 88.79% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.4 88.79% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.5 88.77% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.6 88.77% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.7 88.77% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mysql-5.7 89.52% <ø> (+0.02%) ⬆️
ubuntu-latest_3.7_mysql-8.0 90.99% <ø> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.2 89.43% <ø> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.3 89.43% <ø> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.4 89.43% <ø> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.5 89.41% <ø> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.6 89.41% <ø> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.7 89.41% <ø> (+0.02%) ⬆️
ubuntu-latest_3.8_mysql-5.7 90.11% <ø> (+0.02%) ⬆️
ubuntu-latest_3.8_mysql-8.0 91.48% <ø> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.2 89.28% <ø> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.3 89.28% <ø> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.4 89.28% <ø> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.5 89.26% <ø> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.6 89.26% <ø> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.7 89.26% <ø> (+0.02%) ⬆️
ubuntu-latest_3.9_mysql-5.7 89.97% <ø> (+0.02%) ⬆️
ubuntu-latest_3.9_mysql-8.0 91.34% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiomysql/sa/__init__.py 100.00% <0.00%> (ø)
aiomysql/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12aa64...fc09588. Read the comment docs.

@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

- heavily based on @webknjaz's work on https://github.com/cherrypy/cheroot/blob/b2c619f3e60682b9405a87cea48e8d30801b6048/.github/workflows/ci-cd.yml
- create package before running tests, run tests against same package that will be published
- run nightly tests
- publish package to test pypi for commits to master
- publish package to pypi using workflow_dispatch
- create github tag and release after successful tests on workflow_dispatch
- packaging version is set from `setuptools-scm`
- self-reported `__version__` is dynamically determined using `pkg_resources`
- pyroma is removed due to incompatibilities with `setuptools-scm`: regebro/pyroma#69
@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

@Nothing4You Nothing4You marked this pull request as ready for review February 18, 2022 13:14
CHANGES.txt Outdated Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
aiomysql/__init__.py Outdated Show resolved Hide resolved
aiomysql/__init__.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
Nothing4You and others added 3 commits February 23, 2022 18:47
Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

Nothing4You added a commit that referenced this pull request Mar 14, 2022
- all remaining setuptools configuration is moved from setup.py to setup.cfg
- description is now checked with twine rather than `setup.py check`

Split from #734, including suggestions from @webknjaz

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
@Nothing4You Nothing4You mentioned this pull request Mar 14, 2022
4 tasks
Nothing4You added a commit that referenced this pull request Mar 15, 2022
- all remaining setuptools configuration is moved from setup.py to setup.cfg
- description is now checked with twine rather than `setup.py check`

Split from #734, including suggestions from @webknjaz

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
Nothing4You added a commit that referenced this pull request Mar 15, 2022
- generate aiomysql/_scm_version.py at build time, fallback to `unknown` if it doesn't exist
- include setuptools-scm-git-archive to support versioning in archives from git tags
- install aiomysql package in readthedocs and access generated version to embed in docs

Split from #734, including suggestions from @webknjaz

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
Nothing4You added a commit that referenced this pull request Mar 15, 2022
- generate aiomysql/_scm_version.py at build time, fallback to `unknown` if it doesn't exist
- include setuptools-scm-git-archive to support versioning in archives from git tags
- install aiomysql package in readthedocs and access generated version to embed in docs

Split from #734, including suggestions from @webknjaz

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
@Nothing4You Nothing4You marked this pull request as draft March 16, 2022 00:19
Nothing4You added a commit that referenced this pull request Mar 25, 2022
- all remaining setuptools configuration is moved from setup.py to setup.cfg
- description is now checked with twine rather than `setup.py check`

Split from #734, including suggestions from @webknjaz

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
Nothing4You added a commit that referenced this pull request Mar 25, 2022
- generate aiomysql/_scm_version.py at build time, fallback to `unknown` if it doesn't exist
- include setuptools-scm-git-archive to support versioning in archives from git tags
- install aiomysql package in readthedocs and access generated version to embed in docs

Split from #734, including suggestions from @webknjaz

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
Nothing4You added a commit that referenced this pull request Apr 7, 2022
Use setuptools-scm for versioning

- generate aiomysql/_scm_version.py at build time, fallback to `unknown` if it doesn't exist
- include setuptools-scm-git-archive to support versioning in archives from git tags
- install aiomysql package in readthedocs and access generated version to embed in docs
- fetch git context in workflow to ensure we have all information for setuptools-scm to work
- fetch git context in `make doc`

Split from #734, including suggestions from @webknjaz

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
- replace setup.py with setup.cfg and pyproject.toml in cache key hashing
- check package description with twince instead of setup.py, we no longer have setup.py
…g it, as we want to test the installed wheel
@Nothing4You Nothing4You marked this pull request as ready for review April 7, 2022 22:22
@Nothing4You Nothing4You merged commit dc031e2 into master Apr 10, 2022
@Nothing4You Nothing4You deleted the workflow branch April 10, 2022 01:36
Nothing4You added a commit to Nothing4You/aiomysql that referenced this pull request Apr 10, 2022
Nothing4You added a commit to Nothing4You/aiomysql that referenced this pull request Apr 11, 2022
Nothing4You added a commit that referenced this pull request Apr 11, 2022
andr-04 added a commit to andr-04/aiomysql that referenced this pull request May 13, 2022
* commit '8a32f052a16dc3886af54b98f4d91d95862bfb8e': (92 commits)
  Update changelog for 0.1.1 release (aio-libs#784)
  Bump pytest from 7.1.1 to 7.1.2 (aio-libs#781)
  XFail test_issue_36 for now to avoid failing for unrelated changes (aio-libs#779)
  Skip codecov uploads in scheduled daily tests (aio-libs#778)
  Bump codecov/codecov-action from 3.0.0 to 3.1.0 (aio-libs#777)
  Fix SSL connection handshake charset not respecting client configuration (aio-libs#776)
  Bump ncipollo/release-action from 1.9.0 to 1.10.0 (aio-libs#766)
  Bump actions/cache from 3.0.1 to 3.0.2 (aio-libs#771)
  Bump actions/download-artifact from 2 to 3 (aio-libs#765)
  Bump actions/upload-artifact from 2 to 3 (aio-libs#767)
  Update changelog for release (aio-libs#769)
  Checkout git source to access changelog for GitHub release creation
  Change next version to 0.1.0 in changelog
  Fix GHA badge in readme after aio-libs#734 (aio-libs#762)
  Fix SSCursor raising query timeout error on wrong query on MySQL DB (aio-libs#761)
  Specify explicit language for literal blocks in CONTRIBUTING.rst to reduce warnings in doc builds (aio-libs#760)
  fix `make checkrst` (aio-libs#759)
  Update sphinx requirement from <4.4.1,>=1.8.1 to 4.5.0 (aio-libs#751)
  Bump codecov/codecov-action from 2.1.0 to 3.0.0 (aio-libs#758)
  Bump actions/cache from 2.1.7 to 3.0.1 (aio-libs#752)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPi releases do not always match repo code
2 participants