Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make checkrst #759

Merged
merged 1 commit into from
Apr 10, 2022
Merged

fix make checkrst #759

merged 1 commit into from
Apr 10, 2022

Conversation

Nothing4You
Copy link
Collaborator

What do these changes do?

fix make checkrst to use twine check rather than setup.py check, setup.py was removed in #746.

Are there changes in behavior for the user?

no

Related issue number

fixes #756

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into CHANGES.txt

@Nothing4You Nothing4You added this to the 0.1 milestone Apr 10, 2022
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #759 (a385e0c) into master (a0b7a82) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #759   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files          38       38           
  Lines        5551     5551           
  Branches      941      941           
=======================================
  Hits         5154     5154           
  Misses        309      309           
  Partials       88       88           
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.2 89.38% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.3 89.38% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.4 89.38% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.5 89.37% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.6 89.37% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.7 89.37% <ø> (ø)
ubuntu-latest_3.10_mysql-5.7 90.07% <ø> (ø)
ubuntu-latest_3.10_mysql-8.0 91.46% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.2 89.35% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.3 89.35% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.4 89.35% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.5 89.33% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.6 89.33% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.7 89.33% <ø> (ø)
ubuntu-latest_3.11-dev_mysql-5.7 90.03% <ø> (ø)
ubuntu-latest_3.11-dev_mysql-8.0 91.42% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.2 88.79% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.3 88.79% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.4 88.79% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.5 88.77% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.6 88.77% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.7 88.77% <ø> (ø)
ubuntu-latest_3.7_mysql-5.7 89.52% <ø> (ø)
ubuntu-latest_3.7_mysql-8.0 90.99% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.2 89.43% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.3 89.43% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.4 89.43% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.5 89.41% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.6 89.41% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.7 89.41% <ø> (ø)
ubuntu-latest_3.8_mysql-5.7 90.11% <ø> (ø)
ubuntu-latest_3.8_mysql-8.0 91.48% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.2 89.28% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.3 89.28% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.4 89.28% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.5 89.26% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.6 89.26% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.7 89.26% <ø> (ø)
ubuntu-latest_3.9_mysql-5.7 89.97% <ø> (ø)
ubuntu-latest_3.9_mysql-8.0 91.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b7a82...a385e0c. Read the comment docs.

@Nothing4You Nothing4You merged commit 89011c9 into master Apr 10, 2022
@Nothing4You Nothing4You deleted the fix-make-checkrst branch April 10, 2022 05:28
andr-04 added a commit to andr-04/aiomysql that referenced this pull request May 13, 2022
* commit '8a32f052a16dc3886af54b98f4d91d95862bfb8e': (92 commits)
  Update changelog for 0.1.1 release (aio-libs#784)
  Bump pytest from 7.1.1 to 7.1.2 (aio-libs#781)
  XFail test_issue_36 for now to avoid failing for unrelated changes (aio-libs#779)
  Skip codecov uploads in scheduled daily tests (aio-libs#778)
  Bump codecov/codecov-action from 3.0.0 to 3.1.0 (aio-libs#777)
  Fix SSL connection handshake charset not respecting client configuration (aio-libs#776)
  Bump ncipollo/release-action from 1.9.0 to 1.10.0 (aio-libs#766)
  Bump actions/cache from 3.0.1 to 3.0.2 (aio-libs#771)
  Bump actions/download-artifact from 2 to 3 (aio-libs#765)
  Bump actions/upload-artifact from 2 to 3 (aio-libs#767)
  Update changelog for release (aio-libs#769)
  Checkout git source to access changelog for GitHub release creation
  Change next version to 0.1.0 in changelog
  Fix GHA badge in readme after aio-libs#734 (aio-libs#762)
  Fix SSCursor raising query timeout error on wrong query on MySQL DB (aio-libs#761)
  Specify explicit language for literal blocks in CONTRIBUTING.rst to reduce warnings in doc builds (aio-libs#760)
  fix `make checkrst` (aio-libs#759)
  Update sphinx requirement from <4.4.1,>=1.8.1 to 4.5.0 (aio-libs#751)
  Bump codecov/codecov-action from 2.1.0 to 3.0.0 (aio-libs#758)
  Bump actions/cache from 2.1.7 to 3.0.1 (aio-libs#752)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make checkrst still refers to setup.py
1 participant