Blocks: Register block when invalid value provided for the icon #34350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Blocks
gziolo
commented
Aug 27, 2021
| @@ -25,14 +25,13 @@ import { | |||
| import { applyFilters } from '@wordpress/hooks'; | |||
| import { select, dispatch } from '@wordpress/data'; | |||
| import { _x } from '@wordpress/i18n'; | |||
| import { blockDefault } from '@wordpress/icons'; | |||
There was a problem hiding this comment.
@youknowriad, would it be fine to remove the dependency on @wordpress/icons here?
We map block-default to the same icon anyway:
gutenberg/packages/block-editor/src/components/block-icon/index.js
Lines 13 to 16 in f42fa3a
There was a problem hiding this comment.
Sure, the goal was to illuminate string icons in Gutenberg and it seems we may not be there for a long time still.
2 tasks
gziolo
force-pushed
the
fix/block-registration-invalid-icon
branch
from
d53e92d
to
0977229
Compare
|
Size Change: -189 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
7 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18894.
How has this been tested?
I successfully registered and inserted a block with the icon field set to
icon: nullandicon: ''. I confirmed that the default block icon was used.Types of changes
Bug fix (non-breaking change which fixes an issue). Backward compatibility.
Checklist:
*.native.jsfiles for terms that need renaming or removal).