New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: npm install
fails on CI because of react-native-gesture-handler
#34377
Comments
This seems to happen for new installs as well, @nielslange was trying to setup the repo locally and couldn’t install it. |
I went ahead and set up a brand new Mac Mini, installed
|
With a fresh clone of Gutenberg, I'm getting the same error using |
🤔 is this still reproducible? A fresh install seemed to finish for me. For anyone that can repro, we could maybe try setting "types" or "typeRoots" to an allow list of types to use https://www.typescriptlang.org/tsconfig#types. Not sure why this defaults to pulling in 3rd party deps as visible but 🤷♀️ {
"compilerOptions": {
"types": []
}
} |
I just tried a fresh clone and I'm not sure if the issue was fixed, or I don't have the correct steps to reproduce. |
Still happening for me on latest trunk with
I'm executing on Mac OSX native terminal. Fresh clone of GB trunk.
|
Since the error appears to be happening in a tmp folder, eg:
I tried deleting this tmp folder before attempting |
I was able to repro locally after nuking the npm cache. These are the steps to repro that worked for me, @guarani: rm -rf node_modules
nvm use
npm cache clean --force
npm ci |
Can repro as well with latest trunk (35e16bb) and |
Using File
Command: Log:
|
I get the same error trying to build on Windows 10. Clearing the npm cache didn't help. |
I bumped the priority on this. It's a significant blocker to contributing to the repository right now. |
I may have a theory of what is going on: So
(We consume that package from However, That would explain why cloning If the theory is correct, a potential solution would be to publish Edit: as an experiment, I've published |
Let's see if #34422 helps :) |
Can confirm this fixes things for me 👏🏻 |
While pinning the IMO the root problem is that Gutenberg is taking the job of building an upstream dependency (which introduces a delay when running npm ci/i). As long as we continue to have git urls this will eventually break again. |
After restarting failed jobs for 4813ac8, everything turned green 🎉 Thank you all so much for fixing the issue 🙇🏻
This strategy has also other drawbacks. There are some incompatibilities between npm 6 and 7. Ideally, we should use only original npm packages. |
Description
Any change to the lock file breaks most of the CI jobs, example:
https://github.com/WordPress/gutenberg/pull/34350/checks?check_run_id=3442150008
Related PR: #34350, #34373.
Full error:
Step-by-step reproduction instructions
package.json
file and runnpm i
.I guess it runs
npm ci
on CI and that might be the main difference why I don't see it locally.Screenshots, screen recording, code snippet
No response
Environment info
No response
Pre-checks
The text was updated successfully, but these errors were encountered: