[RNMobile] Fixes unsupported block crash #34499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
|
The "Static Analysis (Linting, License, Type checks...)" CI check is giving the following error: Looks like we would need to re-incorporate the |
|
It looks like the native mobile app is rendering a block icon without wrapping it in the The logic is covered here in the native code: Given that 3rd party blocks can pass a Dashicon string as an icon, it must be handled correctly in other places so it's probably the Missing block that needs to be investigated. |
Thank you for the prompt feedback @gziolo 🙇 |
|
It might be around this code: gutenberg/packages/block-library/src/missing/edit.native.js Lines 278 to 282 in e2e3f6b I hope it's the only place 😅 |
geriux
force-pushed
the
rnmobile/fix/unsupportedBlockCrash
branch
from
fed5dd3
to
88eaeaf
Compare
|
I cannot directly approve this PR but I confirm that @geriux's approach(88eaeaf) is better and resolves the crash 👍 |
2 tasks
|
Thank you for the quick fix. I completely missed the fact that some of those block icons can be handled differently. On the bright side, at least now they have consistent way to render them 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#3910This PR fixes a bug introduced with #34350 causing the mobile application to crash when an unsupported block is tapped.
The issue was happening in the Floating Toolbar, it was using the
Iconcomponent and now uses theBlockIconwrapper.Some changes were done to
BlockIconto support some new props.How has this been tested?
Test case 1
Test case 2
Test case 3
BlockIcone.g.AudioScreenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).