Lock ExecJS and solidus extensions orb version #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExecJS released a minor version update with a breaking change. We want to lock to the previous version (2.7) for now until a fix is released. Co-authored-by: Nick Van Doorn <nick@super.gd> Co-authored-by: Adam Mueller <adam@super.gd>
|
big thanks to @adammathys for helping dig into this gnarly problem! |
nvandoorn
approved these changes
May 12, 2021
jarednorman
approved these changes
May 12, 2021
nvandoorn
force-pushed
the
lock-execjs
branch
3 times, most recently
from
126f065
to
f2208a9
Compare
nvandoorn
changed the title
A new version of `solidusio/extensions` has been released which runs the specs against Solidus 2.11. We are not ready for Solidus 2.11 yet, and the failing CI is blocking things, so we will avoid Solidus 2.11 for now, but we do want to support it eventually.
jarednorman
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
ExecJS released a minor version update with a breaking change. We want to lock to the previous version (2.7) for now until a fix is released.
rails/execjs#99
Merge Checklist