Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock ExecJS and solidus extensions orb version #69

Merged
merged 3 commits into from
May 12, 2021
Merged

Lock ExecJS and solidus extensions orb version #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a99a127
Lock ExecJS version
Noah-Silvera May 12, 2021
268f050
Lock `solidusio/extensions` orb to `0.2.24`
nvandoorn May 12, 2021
e017998
Update changelog
Noah-Silvera May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
version: 2.1
orbs:
# Always take the latest version of the orb, this allows us to
# run specs against Solidus supported versions only without the need
# to change this configuration every time a Solidus version is released
# or goes EOL.
solidusio_extensions: solidusio/extensions@volatile
solidusio_extensions: solidusio/extensions@0.2.24

jobs:
run-specs-with-postgres:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- [#51](https://github.com/SuperGoodSoft/solidus_taxjar/pull/51) Add nexus regions method to API
- [#58](https://github.com/SuperGoodSoft/solidus_taxjar/pull/58) Take shipping promotions into account in default calculator
- [#59](https://github.com/SuperGoodSoft/solidus_taxjar/pull/59) Add pry debugging tools
- [#69](https://github.com/SuperGoodSoft/solidus_taxjar/pull/69) Lock ExecJS version

## v0.18.1

Expand Down
4 changes: 4 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ gem "rails", ENV.fetch("RAILS_VERSION") { ">0.a" }

# Provides basic authentication functionality for testing parts of your engine
gem "solidus_auth_devise"
# ExecJS 2.8 has a bug in it which breaks js precompiling, which is required for our features
# specs. Many other solidus extensions are also experiencing failing specs because of this.
# For now, we should lock the version of ExecJS until a new release comes out that fixes this bug.
gem "execjs", '~> 2.7.0'

case ENV["DB"]
when "mysql"
Expand Down