Skip to content

Commit

Permalink
Lock ExecJS version
Browse files Browse the repository at this point in the history
ExecJS released a minor version update with a breaking change. We want
to lock to the previous version (2.7) for now until a fix is released.

Co-authored-by: Nick Van Doorn <nick@super.gd>
  • Loading branch information
Noah-Silvera and nvandoorn committed May 12, 2021
1 parent d4553b0 commit 581864a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ gem "rails", ENV.fetch("RAILS_VERSION") { ">0.a" }

# Provides basic authentication functionality for testing parts of your engine
gem "solidus_auth_devise"
# ExecJS 2.8 has a bug in it which breaks js precompiling, which is required for our features
# specs. Many other solidus extensions are also experiencing failing specs because of this.
# For now, we should lock the version of ExecJS until a new release comes out that fixes this bug.
gem "execjs", '~> 2.7.0'

case ENV["DB"]
when "mysql"
Expand Down

0 comments on commit 581864a

Please sign in to comment.