Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.26.1 to 1.28.2 #379

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 25, 2022

Bumps rubocop from 1.26.1 to 1.28.2.

Release notes

Sourced from rubocop's releases.

RuboCop 1.28.2

Bug fixes

  • #10566: Fix a false positive for Lint/AmbiguousBlockAssociation when using proc is used as a last argument. (@​koic)
  • #10573: Fix a false positive for Layout/SpaceBeforeBrackets when there is a dot before brackets. (@​nobuyo)
  • #10563: Fix Style/BlockDelimiters unexpectedly deletes block on moving comment if methods with block are chained. (@​nobuyo)
  • #10574: Fix a false positive for Style/SingleArgumentDig when using dig with arguments forwarding. (@​ydah)
  • #10565: Fix a false positive and a true negative for Style/FetchEnvVar. (@​koic)

RuboCop 1.27

New features

Bug fixes

  • #10464: Fix an incorrect autocorrect for Lint/IncompatibleIoSelectWithFiberScheduler when using IO.select with read (or write) argument and using return value. (@​koic)
  • #10506: Fix an error for Style/RaiseArgs when raise with new method without receiver. (@​koic)
  • #10479: Fix a false positive for Lint/ShadowingOuterLocalVariable conditional statement and block variable. (@​ydah)
  • #10189: Fix --display-style-guide so it works together with --format offenses. (@​jonas054)
  • #10465: Fix false positive for Naming/BlockForwarding when the block argument is assigned. (@​dvandersluis)
  • #10491: Improve the handling of comments in Lint/EmptyConditionalBody, Lint/EmptyInPattern and Lint/EmptyWhen when AllowComments is set to true. (@​Darhazer)
  • #10504: Fix a false positive for Lint/UnusedMethodArgument when using raise NotImplementedError with optional arguments. (@​koic)
  • #10494: Fix a false positive for Style/HashSyntax when return with one line if condition follows (without parentheses). (@​koic)
  • #10311: Fix false negative inside do..end for Layout/RedundantLineBreak. (@​jonas054)
  • #10468: Fix a false positive for Style/FileWrite when a splat argument is passed to f.write. (@​koic)
  • #10474: Fix a false positive for Style/DoubleNegation with EnforcedStyle: allowed_in_returns when inside returned conditional clauses. (@​ydah)
  • #10388: Fix an incorrectly adds a disable statement for Layout/SpaceInsideArrayLiteralBrackets with --disable-uncorrectable. (@​ydah)
  • #10489: Fix a false positive for Lint/LambdaWithoutLiteralBlock when using lambda with a symbol proc. (@​koic)

Changes

  • #10191: Add MaxChainLength option to Style/SafeNavigation and the option is 2 by default. (@​ydah)
Changelog

Sourced from rubocop's changelog.

1.28.2 (2022-04-25)

Bug fixes

  • #10566: Fix a false positive for Lint/AmbiguousBlockAssociation when using proc is used as a last argument. ([@​koic][])
  • #10573: Fix a false positive for Layout/SpaceBeforeBrackets when there is a dot before brackets. ([@​nobuyo][])
  • #10563: Fix Style/BlockDelimiters unexpectedly deletes block on moving comment if methods with block are chained. ([@​nobuyo][])
  • #10574: Fix a false positive for Style/SingleArgumentDig when using dig with arguments forwarding. ([@​ydah][])
  • #10565: Fix a false positive and a true negative for Style/FetchEnvVar. ([@​koic][])

1.28.1 (2022-04-21)

Bug fixes

  • #10559: Fix crash on CodeLengthCalculator if method call is not parenthesized. ([@​nobuyo][])
  • #10557: Fix a false positive for Style/FetchEnvVar when ENV['key'] is a receiver of ||=. ([@​koic][])

1.28.0 (2022-04-21)

New features

Bug fixes

  • #10528: Fix an infinite loop at autocorrect for Layout/CaseIndentation. ([@​ydah][])
  • #10537: Fix an incorrect auto-correct for Style/MultilineTernaryOperator when returning a multiline ternary operator expression with break, next, or method call. ([@​koic][])
  • #10529: Fix autocorrect for Style/SoleNestedConditional causes logical error when using a outer condition of method call by omitting parentheses for method arguments. ([@​nobuyo][])
  • #10530: Fix a false positive for Style/RedundantRegexpCharacterClass when using regexp character class with a character class containing multiple unicode code-points. ([@​koic][])
  • #10518: Fix a false positive for Style/DoubleNegation when inside returned conditional clauses with Ruby 2.7's pattern matching. ([@​koic][])
  • #10510: Fix an error for Style/SingleArgumentDig when using multiple dig in a method chain. ([@​koic][])
  • #10553: Fix crash with trailing tabs in heredocs for Layout/TrailingWhitespace. ([@​dvandersluis][])
  • #10488: Fix autocorrection for Layout/MultilineMethodCallIndentation breaks indentation for nesting of method calls. ([@​nobuyo][])
  • #10543: Fix incorrect code length calculation for few more patterns of hash folding asked. ([@​nobuyo][])
  • #10541: Fix an incorrect autocorrect for Style/SpecialGlobalVars when global variable as Perl name is used multiple times. ([@​koic][])
  • #10514: Fix an error for Lint/EmptyConditionalBody when missing second elsif body. ([@​koic][])
  • #10469: Fix code length calculation when kwargs written in single line. ([@​nobuyo][])

Changes

  • #10555: Deprecate IgnoredPatterns in favour of AllowedPatterns. ([@​dvandersluis][])
  • #10356: Add AllowConsecutiveConditionals option to Style/GuardClause and the option is false by default. ([@​ydah][])
  • #10524: Mark Style/RedundantInitialize as unsafe. ([@​koic][])

... (truncated)

Commits
  • 7222575 Cut 1.28.2
  • e9fc354 Update Changelog
  • 135bddb Merge pull request #10575 from nobuyo/fix-false-positive-for-layout-space-bef...
  • 490cb62 [Fix #10573] Fix a false positive for Layout/SpaceBeforeBrackets when there...
  • 7606e2c Merge pull request #10565 from ydah/fix_fetch_env_var
  • d8f3c8f Fix a false positive and a true negative for Style/FetchEnvVar
  • df09f42 Merge pull request #10576 from ydah/fix_single_argment_dig
  • dd8bf68 [Fix #10574] Fix a false positive for Style/SingleArgumentDig when using di...
  • a331f43 Merge pull request #10564 from nobuyo/fix-unexpected-block-deletion-when-styl...
  • f6e97b4 Merge pull request #10567 from koic/fix_a_false_positive_for_lint_ambiguous_b...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.26.1 to 1.28.2.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.26.1...v1.28.2)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Apr 25, 2022
@sambostock
Copy link
Contributor

sambostock commented Apr 25, 2022

This is effectively a duplicate of #377, which aims to address the

IgnoredPatterns has been renamed to AllowedPatterns

problem which this PR's CI is encountering, by updating Rubocop and the config.

@sambostock sambostock closed this Apr 25, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 25, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@sambostock sambostock deleted the dependabot/bundler/rubocop-1.28.2 branch April 25, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant