Fix an incorrect auto-correct for Style/MultilineTernaryOperator
#10537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_an_incorrect_autocorrect_for_style_multiline_ternary_operator
branch
4 times, most recently
from
a6126e1
to
42c19cb
Compare
Follow up rubocop#8661. This PR fixes an incorrect auto-correct for `Style/MultilineTernaryOperator` when returning a multiline ternary operator expression. Using `break`, `next`, or method call also causes the same syntax error as `return`. And this PR will change these auto-correct to single-line ternary operator as valid syntax.
koic
force-pushed
the
fix_an_incorrect_autocorrect_for_style_multiline_ternary_operator
branch
from
42c19cb
to
69ed7d5
Compare
|
Nicely done! |
koic
deleted the
fix_an_incorrect_autocorrect_for_style_multiline_ternary_operator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #8661.
This PR fixes an incorrect auto-correct for
Style/MultilineTernaryOperatorwhen returning a multiline ternary operator expression. Usingbreak,next, or method call also causes the same syntax error asreturn.And this PR will change these auto-correct to single-line ternary operator as valid syntax.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.