Fix a false positive for Style/DoubleNegation
#10518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following false positive for
Style/DoubleNegation
when inside returned conditional clauses with Ruby 2.7's pattern matching.The following is a reproduction case.
It is expected that an offense will not be registered, but in actually an offense will be registered.
This is a follow-up to the same issue as #10474 and requires RuboCop AST 1.7 to fix. Therefore it bumps RuboCop AST required to use rubocop/rubocop-ast#227 to 1.7 or higher.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.