Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Style/DoubleNegation #10518

Merged

Conversation

koic
Copy link
Member

@koic koic commented Apr 9, 2022

This PR fixes the following false positive for Style/DoubleNegation when inside returned conditional clauses with Ruby 2.7's pattern matching.

The following is a reproduction case.

def foo?
  case condition
  in foo
    !!foo
  in bar
    !!bar
  else
    !!baz
  end
end

It is expected that an offense will not be registered, but in actually an offense will be registered.

% bundle exec rubocop --only Style/DoubleNegation
(snip)

Inspecting 2 files
C.

Offenses:

example.rb:4:5: C: [Correctable] Style/DoubleNegation: Avoid the use of double negation (!!).
    !!foo
    ^
example.rb:6:5: C: [Correctable] Style/DoubleNegation: Avoid the use of double negation (!!).
    !!bar
    ^

2 files inspected, 2 offenses detected, 2 offenses auto-correctable

This is a follow-up to the same issue as #10474 and requires RuboCop AST 1.7 to fix. Therefore it bumps RuboCop AST required to use rubocop/rubocop-ast#227 to 1.7 or higher.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following false positive for `Style/DoubleNegation`
when inside returned conditional clauses with Ruby 2.7's pattern matching.

The following is a reproduction case.

```ruby
def foo?
  case condition
  in foo
    !!foo
  in bar
    !!bar
  else
    !!baz
  end
end
```

It is expected that an offense will not be registered, but in actually
an offense will be registered.

```console
% bundle exec rubocop --only Style/DoubleNegation
(snip)

Inspecting 2 files
C.

Offenses:

example.rb:4:5: C: [Correctable] Style/DoubleNegation: Avoid the use of double negation (!!).
    !!foo
    ^
example.rb:6:5: C: [Correctable] Style/DoubleNegation: Avoid the use of double negation (!!).
    !!bar
    ^

2 files inspected, 2 offenses detected, 2 offenses auto-correctable
```

This is a follow-up to the same issue as rubocop#10474 and requires RuboCop AST 1.7 to fix.
Therefore it bumps RuboCop AST required to use rubocop/rubocop-ast#227
to 1.7 or higher.
@koic koic force-pushed the fix_a_false_positive_for_style_double_negation branch from cf3540b to 1ef4d6e Compare April 9, 2022 16:29
@koic koic merged commit 1ad6189 into rubocop:master Apr 12, 2022
@koic koic deleted the fix_a_false_positive_for_style_double_negation branch April 12, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant