Bump SharpZipLib from 1.3.3 to 1.4.2 #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [SharpZipLib](https://github.com/icsharpcode/SharpZipLib) from 1.3.3 to 1.4.2. - [Release notes](https://github.com/icsharpcode/SharpZipLib/releases) - [Changelog](https://github.com/icsharpcode/SharpZipLib/blob/master/docs/Changes.txt) - [Commits](icsharpcode/SharpZipLib@v1.3.3...v1.4.2) --- updated-dependencies: - dependency-name: SharpZipLib dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Last time I tried to update the zip lib that broke saving or loading (I can't remember which, or maybe it was both). So this needs some careful checking and maybe even code fixing before merging. |
|
I opened a bug report: icsharpcode/SharpZipLib#827 |
|
I think I found a workaround by switching the GZip stream type to be the system standard from .NET. |
saving and loading works after this change in all my tests
|
Both saves from older versions, and new saves seem to load just fine without error! |
hhyyrylainen
approved these changes
Feb 24, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps SharpZipLib from 1.3.3 to 1.4.2.
Release notes
Sourced from SharpZipLib's releases.
... (truncated)
Commits
33f64ebbump version to v1.4.2c51ef18chore: add issue form templates (#817)68e2f92fix(zip): fully implement async deflate (#813)c4009fdfix(tar): enable async overrides on net6 (#811)58b5c4etest: update deps for net7 support (#812)cbb9e83zip: finish stream async when async (#808)77c5a97fix(zip): remove leftover console logging (#809)cdd0931bump version to v1.4.1a389d9ffix(zip): cleanup/fix of StringCodec (#778)23becfdfix(tar): use sync codepath on sync methods (#791)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)