fix(zip): cleanup/fix of StringCodec #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news on this one? It's blocking us from updating to the latest NuGet. |
|
Sorry, I have been busy with work. There are some inconsistencies in the API that I need to look over, but it should mostly be done. |
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 74.70% 74.72% +0.01%
==========================================
Files 72 72
Lines 8465 8485 +20
==========================================
+ Hits 6324 6340 +16
- Misses 2141 2145 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues that were present in #592 but wasn't detected before the release of v1.4.0.
In general, it goes a bit further in trying to make the string encoding easy and predictable to use.
It also has tests for the most common usages of the API to make sure it both works and feels straightforward to use.
The changes in the API are slightly breaking from v1.4.0, but only where the API could be misused in confusing ways. It should not require any minor version bump, but should be released ASAP to limit the effect.
Fixes #777.
Fixes #776.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.