Add unsafe modifier when necessary

PublicApiGenerator · Nov 2, 2019 · fabfb46 · fabfb46
1 parent 134ad56
commit fabfb46
Showing 1 changed file with 27 additions and 0 deletions.
diff --git a/src/PublicApiGenerator/ApiGenerator.cs b/src/PublicApiGenerator/ApiGenerator.cs
@@ -626,6 +626,9 @@ static void AddMethodToTypeDeclaration(CodeTypeDeclaration typeDeclaration, Meth
 
             var returnType = member.ReturnType.CreateCodeTypeReference(member.MethodReturnType);
 
+            if (IsUnsafeSignatureType(member.ReturnType) || member.Parameters.Any(p => IsUnsafeSignatureType(p.ParameterType)))
+                returnType = MakeUnsafe(returnType);
+
             var method = new CodeMemberMethod
             {
                 Name = memberName,
@@ -640,6 +643,22 @@ static void AddMethodToTypeDeclaration(CodeTypeDeclaration typeDeclaration, Meth
             typeDeclaration.Members.Add(method);
         }
 
+        static bool IsUnsafeSignatureType(TypeReference typeReference)
+        {
+            while (true)
+            {
+                if (typeReference.IsPointer) return true;
+
+                if (typeReference.IsArray || typeReference.IsByReference)
+                {
+                    typeReference = typeReference.GetElementType();
+                    continue;
+                }
+
+                return false;
+            }
+        }
+
         static bool IsExtensionMethod(ICustomAttributeProvider method)
         {
             return method.CustomAttributes.Any(a => a.AttributeType.FullName == "System.Runtime.CompilerServices.ExtensionAttribute");
@@ -889,6 +908,9 @@ static void AddFieldToTypeDeclaration(CodeTypeDeclaration typeDeclaration, Field
             var codeTypeReference = memberInfo.FieldType.CreateCodeTypeReference(memberInfo);
             if (memberInfo.IsInitOnly)
                 codeTypeReference = MakeReadonly(codeTypeReference);
+            if (IsUnsafeSignatureType(memberInfo.FieldType))
+                codeTypeReference = MakeUnsafe(codeTypeReference);
+
             var field = new CodeMemberField(codeTypeReference, memberInfo.Name)
             {
                 Attributes = attributes,
@@ -906,6 +928,11 @@ static CodeTypeReference MakeReadonly(CodeTypeReference typeReference)
             return ModifyCodeTypeReference(typeReference, "readonly");
         }
 
+        static CodeTypeReference MakeUnsafe(CodeTypeReference typeReference)
+        {
+            return ModifyCodeTypeReference(typeReference, "unsafe");
+        }
+
         static CodeTypeReference ModifyCodeTypeReference(CodeTypeReference typeReference, string modifier)
         {
             using (var provider = new CSharpCodeProvider())